[3.4.4] Last loop element partially done

[nolme]

Hi,

I'm pretty new to Python so my IDE is based on a tuto (because the final goal will use Qt4). So, for the moment, I used the strict version as in the tuto.

Here's my code :

url = 'https://www.test.com'

for i in range(5):
  print(url + str(i))
  print('dl')
  f = open(str(i) + ".html", "wt")
  f.write('test')
  f.close

print ('end')

All files are generated but the last one is always empty. Did I miss something ?

Thanks,
Vincent

---

(seems to be the same problem with 3.6.5 both under Windows environment)

[Gribouillis]

I see one mistake: f.close should be f.close(). Can you describe precisely all the files' content after you run the code?

[buran]

it's better to use with:

for i in range(5):
    with open('{}.html'.format(i), "w") as f:
        f.write('test')

[nolme]

I see one mistake: f.close should be f.close().

YES !!! :) Thanks, it works.

---

it's better to use with:

for i in range(5): with open('{}.html'.format(i), "w") as f: f.write('test')

very more compact version. Harder for me to read for the moment but I keep in mind this way. thanks.

[buran]

with is context manager. It will close the file for you, so no need to use f.close()
.format() is better than string concatenation - e.g. no need to cast the int to str

[snippsat]

(seems to be the same problem with 3.6.5 both under Windows environment)

With 3.6 can also make it more readable with f-string.

for numb in range(5):
    with open(f'{numb}.html', "w") as f:
        f.write('test')