CookBook Project on github

[menator01]

I've added my guestbook project to github. I'm not sure how github works as this is my first time trying.
I've added some bells and whistles so to speak if you want to give it a try and let me know what you think.
This was written on an Ubuntu system. Probably will not work on windows without some tweaks.
All comments are welcomed.
https://github.com/menator01/cookbook

[menator01]

Well found a bug. If a recipe that does not start with a, is not added before closing. The 2nd time it's ran gives, could not find a listing for a, and it shuts down.
So my todo is, just pull the first recond found then, have it go back to picking menus by letter.

[menator01]

Added a small video display
In the post above I said I wasn't sure about it working on a windows os. It worked on mine. The looks are not the same though.

[scratchmyhead]

Interesting. I will try that.

[ndc85430]

I haven't really got time to look much at the code in detail, but a couple of quick things:

1. Commit messages: make sure they're useful - "commit" tells you nothing really about what that commit changes. I know you can look at the diff, but having a short summary lets you know at a glance. Commits should be small enough that you can describe a change in a short sentence. Why? A commit that's hard to describe is likely making lots of changes at once and that's bad because if you need to undo something, it won't be easy.

2. You don't really need to list the directory structure in the README. People can see the structure.

3. In your database code, you're using f-strings to parameterise your SQL statements. Don't do that, as it's vulnerable to SQL injection. Instead, you should be using parameter substitution placeholders. For SQLite, those are ? characters (see the docs) and you'll be able to find out the ones for MySQL in their docs too.