Bottom Page

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
 My code is taking longer time to give result
#1
I am newbie to Python and tried to write a code to get smallest positive number that is evenly divisible by all of the numbers from 1 to 20. I used the script provided below. It is taking more time to get the result.
How can I tweak this code to get the result sooner.
a=1
while True:
	n=0
	for y in range(1,21):
		if a%y==0:
			n=n+1
	if n==20:
		print(a)
		break
	else:
		a=a+1
Quote
#2
> that is evenly divisible by all of the numbers from 1 to 20

That would be 20 by definition. Look at your assignment again. You have read it wrong.
Quote
#3
2520 is the smallest number that can be divided by each of the numbers from 1 to 10 without any remainder.

What is the smallest positive number that is evenly divisible by all of the numbers from 1 to 20?
Quote
#4
The problem here is that you're trying to brute-force the solution by testing every number.
Since the solution is quite large, this will take some time.

Project Euler problems (which this is, even if you found it elsewhere) often require some clever optimization or specific mathematical knowledge.

In this case, you need to know how divisibility works, https://en.wikipedia.org/wiki/Divisibili...e_divisors should be of help.
Once you do, you just need a single calculation to get a solution.
Quote
#5
Don't search for it, build it. Start with 1. 1 evenly divides into that. 2 does not, and there is no common divisor, so multiply by 2 to get 2. 3 does not evenly divide into 2, and there is no common divisor, so multiply by 3 to get 6. 4 does not divide into 6 evenly, but it has a common divisor of 2. So multiply 6 by (4 / 2) to get 12. Keep going up to 20.

You would need to build a greatest common divisor function, (or use the one in the math or fractions module), but then you can build it piece by piece rather than searching for it, which should be faster.
Craig "Ichabod" O'Brien - xenomind.com
I wish you happiness.
Recommended Tutorials: BBCode, functions, classes, text adventures

Quote

Top Page

Possibly Related Threads...
Thread Author Replies Views Last Post
  The count variable is giving me a hard time in this code D4isyy 2 78 Aug-09-2020, 10:32 PM
Last Post: bowlofred
  Having a hard time combining two parts of code. Coozeki 6 497 May-10-2020, 06:50 AM
Last Post: Coozeki
  [Beginner] Code is not producing desired result fakej171 2 397 Mar-21-2020, 10:26 AM
Last Post: buran
  How to avoid open and save a url every time I run code davidm 4 371 Mar-03-2020, 10:37 PM
Last Post: snippsat
  Help to reduce time to execute the code prakash52kar 1 307 Oct-14-2019, 10:56 AM
Last Post: scidam
  Post JSON from python to PHP don't give expected result pgagnebin 1 543 Sep-04-2019, 10:29 PM
Last Post: micseydel
  Code scrape more than one time information Clnprof 5 398 Aug-26-2019, 09:26 AM
Last Post: Clnprof
  Two lines of code at the same time? OTO1012 1 500 Mar-04-2019, 05:32 PM
Last Post: ichabod801
  Catching exceptions in embedded code no longer works on 3.7.2? FFMG 5 661 Feb-02-2019, 10:15 AM
Last Post: Larz60+
  Use a block of code only one time rlinux57 14 1,758 Sep-21-2018, 12:53 PM
Last Post: rlinux57

Forum Jump:


Users browsing this thread: 1 Guest(s)