Python Forum
My code is taking longer time to give result
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
My code is taking longer time to give result
#1
I am newbie to Python and tried to write a code to get smallest positive number that is evenly divisible by all of the numbers from 1 to 20. I used the script provided below. It is taking more time to get the result.
How can I tweak this code to get the result sooner.
a=1
while True:
	n=0
	for y in range(1,21):
		if a%y==0:
			n=n+1
	if n==20:
		print(a)
		break
	else:
		a=a+1
Reply
#2
> that is evenly divisible by all of the numbers from 1 to 20

That would be 20 by definition. Look at your assignment again. You have read it wrong.
Reply
#3
2520 is the smallest number that can be divided by each of the numbers from 1 to 10 without any remainder.

What is the smallest positive number that is evenly divisible by all of the numbers from 1 to 20?
Reply
#4
The problem here is that you're trying to brute-force the solution by testing every number.
Since the solution is quite large, this will take some time.

Project Euler problems (which this is, even if you found it elsewhere) often require some clever optimization or specific mathematical knowledge.

In this case, you need to know how divisibility works, https://en.wikipedia.org/wiki/Divisibili...e_divisors should be of help.
Once you do, you just need a single calculation to get a solution.
Reply
#5
Don't search for it, build it. Start with 1. 1 evenly divides into that. 2 does not, and there is no common divisor, so multiply by 2 to get 2. 3 does not evenly divide into 2, and there is no common divisor, so multiply by 3 to get 6. 4 does not divide into 6 evenly, but it has a common divisor of 2. So multiply 6 by (4 / 2) to get 12. Keep going up to 20.

You would need to build a greatest common divisor function, (or use the one in the math or fractions module), but then you can build it piece by piece rather than searching for it, which should be faster.
Craig "Ichabod" O'Brien - xenomind.com
I wish you happiness.
Recommended Tutorials: BBCode, functions, classes, text adventures
Reply


Possibly Related Threads…
Thread Author Replies Views Last Post
  Code works but doesn't give the right results colin_dent 2 674 Jun-22-2023, 06:04 PM
Last Post: jefsummers
  Beginner: Code not work when longer list raiviscoding 2 763 May-19-2023, 11:19 AM
Last Post: deanhystad
  math formula does not give the same result as bash script [SOLVED] AlphaInc 3 920 Apr-02-2023, 07:21 PM
Last Post: AlphaInc
  help me simple code result min and max number abrahimusmaximus 2 869 Nov-12-2022, 07:52 AM
Last Post: buran
  a longer docstring Skaperen 8 1,591 Aug-25-2022, 11:21 PM
Last Post: Skaperen
  Give visit number ( or counter) within the same time frame balthordu 1 912 Jun-27-2022, 09:51 AM
Last Post: Larz60+
  Can a program execute code in iPython shell and get result? deanhystad 3 1,660 Jun-17-2022, 03:45 AM
Last Post: Larz60+
  code running for more than an hour now, yet didn't get any result, what should I do? aiden 2 1,420 Apr-06-2022, 03:41 PM
Last Post: Gribouillis
  Schedule a task and render/ use the result of the task in any given time klllmmm 2 2,033 May-04-2021, 10:17 AM
Last Post: klllmmm
  Assistance with running a few lines of code at an EXACT time nethatar 5 3,165 Feb-24-2021, 10:43 PM
Last Post: nilamo

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020