Python 3 Module Import Help

[stullis]

Just to confirm, the second code is the one you're importing, correct? I thought it was the main() call at first too, but I understood that to be your program, not the imported module.

[Larz60+]

did you properly indent main?
Are there other places where you automatically execute code in module 1?
each of these will have to be qualified with similar code to prevent the module from executing.
If you don't have any hard coded code execution statements, nothing should execute upon import

i thought the first script was being imported into the second, but I see now that it's the other way around, and I just noticed that the second script was 'C'. That's a different ball game.

[Stealthychu]

Yes, the second script is the one i wish to import, the one with the first command as:

from getpass import getpass

yes, i believe so, how do i properly insert a message to my post? I don't want to do it incorrectly but not sure from the post you linked earlier how to send one to see how i indented it correctly.

[stullis]

The problem with the second one is that it is just a script. On import, it will execute once and be done. To stop this, you need to organize the code into functions that can be called in your main code. Any code that is not part of a function body is executed on import.

[Stealthychu]

So in order to have it all imported and executed at once when requested i would have to include all of the contents of the external file into one big function?

[Larz60+]

most of the code in the second script is not within function definition and by nature of that will execute immediately on loading code.
You will have to place this code in functions so that this doesn't happen.

you can fix this by placing code in functions like:

def startup():
    # This ask the user to enter their SSH username to create a variable.
    # It then requests the user to enter their SSH password to create a second variable.

    username = input('Please enter your SSH username: ')
    password = getpass()

    # This opens the file 'routercommands_file' for use in the script.

    with open('routercommands_file') as f:
        commands_list = f.read().splitlines()

        # This opens the file 'routerdevices_file' for use in the script.

    with open('routerdevices_file') as f:
        devices_list = f.read().splitlines()

and again at end:

if __name__ == '__main__':
    startup()

and I see not 'C', the dictionary threw me off for a second

[Stealthychu]

okay so after creating it as a function in the form you have said i simply call that function in the location i want it to run within my main script and it should work.

I'm assuming 'startup():' is a custom name that you can give the function at your own desire?

would i have to type:
Larz60+
if _name_ == '_main_' :
startup()
[/python]

for each external file i wanted to import or just add a list of file names indented under:

if _name_ == '_main_' :

[stullis]

The line

if __name__ == '__main__' :

is used to prevent code from running unless you are using that module as the main module. It is often used for short tests of a module. It is not required.

[Stealthychu]

So, setting it as a function should solve the problem I am having without having to add in the bit about:

if _name_ == '_main_' :

---

After the script has been defined as a function what command would be entered into the main script to call that specific function when needed?

sorry for all the questions, im quite new to python and modules overall.

---

By creating the second script into a function it has now stopped it from automatically starting, so thank you both very much for that, im just hoping to find out how to call it now if either of you are able to help? :)

[Larz60+]

you must indent code under:
if __name__ == ''__main__':

Otherwise it will have no effect.