Text file information retreval

[cel]

Hi,
Im making a password cracker 'proof of concept' were the program accesses a text file and compares the entered password to a list of common passwords before trying random combinations of alphabetical letters.
The problem I'm having is sometimes the program does not recognize a password in the text file.

Any suggestions?

from random import *


guess = ""
# guesses = []

NH = input("1 for normal or 2 for advanced?:\n")
password = input("password:\n")

normal = ["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v",
           "w", "x", "y", "z"]

advanced = ["a", "b", "c", "d", "e", "f", "g", "h", "i", "j", "k", "l", "m", "n", "o", "p", "q", "r", "s", "t", "u", "v",
           "w", "x", "y", "z", "A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P", "Q", "R",
           "S", "T", "U", "V", "W", "X", "Y", "Z", "1", "2", "3", "4", "5", "6", "7", "8", "9", "0"]

dictionary = open("pw_dictionary", "r")

print(1)
for entry in dictionary:
    print(2)
    if entry == password:
        print(3)
        guess = entry
dictionary.close()

if NH == "1":
        while guess != password:
            guess = ""
            for letter in password:
                guessletters = normal[randint(0, 25)]
                guess = str(guessletters) + str(guess)
                print(guess)
        print("Password cracked")
else:
    while guess != password:
        guess = ""
        for letter in password:
            guessletters = advanced[randint(0, 61)]
            guess = str(guessletters) + str(guess)
            print(guess)

if guess == password:
    dictionary = open("pw_dictionary", "a")
    dictionary.write("\n" + str(guess))
    dictionary.close()

    print("Password cracked")

P.S.
pw_dictionary is the name of the text file

[bowlofred]

When you use input() note that it does not include a trailing newline. input

But when you iterate over the opened file object, newlines are not removed, and you're not doing that in the code. So the string read from the file will never be equal to the input string. rstrip() would be useful here.

Also, consider using string.ascii_lowercase and string.ascii_letters + string.digits instead of the hardcoded lists of letters.

[cel]

sorry I'm new to coding I don't understand what you mean "new lines are not removed"

[Yoriz]

just like in your code you have

NH = input("1 for normal or 2 for advanced?:\n")

the \n gives you a new line.
the lines read from the file end with a newline.

when I enter text to my post pressing enter
gives me a new line.

[cel]

Thank you, it turns out the problem was with the new line