Bottom Page

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
 Why doesn't my loop work correctly? (problem with a break statement)
#1
Hey guys I'm having some trouble with a loop in python I`m working on. I simplified the code for this question since the core of the problem stays the same and it makes it easier to understand: So lets say I create two classes, one for Apples and one for Bananas. Their attributes are basically the same (name, color and price).

I wanted to define a method for the banana class which iterates over a list of apples and check first whether the price of the banana is the same as for one of the apple objects. If that is the case, the banana should take over that apple's name (again, it doesnt make any sense in this code, but its relevant for the actual project I'm working on). In the second place, the method is supposed to check whether the banana has the same color as one of the apple objects and then take over that apples name (I used an elif statement for that one).

Now, whenever I try to run that code with the 3 Banana objects, Banana1 and 3 are assigned to the correct Apple,but Banana2 is assigned to Apple1 even though it should be assigned to Apple 2. I experimented a bit and found out that when I remove the break statement at the end of my elif condition which checks for the matching color all Bananas are assigned to the correct Apple. However, since I would like to set up another elif condition I cannot delete that break statement, right?
If anyone could help me to understand what is wrong with my code I would be very grateful. Sorry if there is an obvious solution for this problem, I'm very new to python programming. Thanks in advance for your help! Heres the full code:

class Apple:                                      
    def __init__(self, name, color, price):
        self.name = name
        self.color = color
        self.price = price

A1=Apple("Apple1", "red", 5)
A2=Apple("Apple2", "yellow", 3)
A3=Apple("Apple3", "green", 10 )

Apple_List=[A1, A2, A3]

class Banana:
    def __init__(self, name, color, price):
        self.name = name
        self.color = color
        self.price= price

    def evaluate(self):
        for a in Apple_List:
            if self.price==a.price:
                self.name=a.name
                break

            elif self.color==a.color:
                self.name=a.name
                break

        print(self.name)


B1=Banana("Banana1","yellow", 5)
B2=Banana("Banana2", "red", 3)
B3=Banana("Banana3", "green", 7)

B1.evaluate()
B2.evaluate()
B3.evaluate()
Quote
#2
Every time you evaluate, you are looping the entire list. Apple1 which has the same color as banana2, is executed per the elif condition.
Output:
apple = {'name': 'Apple1', 'color': 'red', 'price': 5} banana = {'name': 'Banana2', 'color': 'red', 'price': 3} changing name of Banana2 to Apple1 based on color
I usually put prints around to quickly identify control

With break:
    def evaluate(self):
        for a in Apple_List:
            print(f'apple = {a.__dict__}')
            print(f'banana = {self.__dict__}')
            if self.price==a.price:
                print(f'changing name of {self.name} to {a.name} based on price')
                self.name=a.name
                break
 
            elif self.color==a.color:
                print(f'changing name of {self.name} to {a.name} based on color')
                self.name=a.name
                break
            else:
                print('else clause')
 
        print(self.name)
Output:
metulburr@ubuntu:~$ python3.6 test3.py apple = {'name': 'Apple1', 'color': 'red', 'price': 5} banana = {'name': 'Banana1', 'color': 'yellow', 'price': 5} changing name of Banana1 to Apple1 based on price Apple1 apple = {'name': 'Apple1', 'color': 'red', 'price': 5} banana = {'name': 'Banana2', 'color': 'red', 'price': 3} changing name of Banana2 to Apple1 based on color Apple1 apple = {'name': 'Apple1', 'color': 'red', 'price': 5} banana = {'name': 'Banana3', 'color': 'green', 'price': 7} else clause apple = {'name': 'Apple2', 'color': 'yellow', 'price': 3} banana = {'name': 'Banana3', 'color': 'green', 'price': 7} else clause apple = {'name': 'Apple3', 'color': 'green', 'price': 10} banana = {'name': 'Banana3', 'color': 'green', 'price': 7} changing name of Banana3 to Apple3 based on color Apple3
commenting out the elif break makes it look as you expected because ut changes banana name to apples for the next evaluation.
Output:
metulburr@ubuntu:~$ python3.6 test3.py apple = {'name': 'Apple1', 'color': 'red', 'price': 5} banana = {'name': 'Banana1', 'color': 'yellow', 'price': 5} changing name of Banana1 to Apple1 based on price Apple1 apple = {'name': 'Apple1', 'color': 'red', 'price': 5} banana = {'name': 'Banana2', 'color': 'red', 'price': 3} changing name of Banana2 to Apple1 based on color apple = {'name': 'Apple2', 'color': 'yellow', 'price': 3} banana = {'name': 'Apple1', 'color': 'red', 'price': 3} changing name of Apple1 to Apple2 based on price Apple2 apple = {'name': 'Apple1', 'color': 'red', 'price': 5} banana = {'name': 'Banana3', 'color': 'green', 'price': 7} else clause apple = {'name': 'Apple2', 'color': 'yellow', 'price': 3} banana = {'name': 'Banana3', 'color': 'green', 'price': 7} else clause apple = {'name': 'Apple3', 'color': 'green', 'price': 10} banana = {'name': 'Banana3', 'color': 'green', 'price': 7} changing name of Banana3 to Apple3 based on color Apple3
Quote
#3
(Jun-09-2019, 02:08 PM)steckinreinhart619 Wrote: Hey guys I'm having some trouble with a loop in python I`m working on. I simplified the code for this question since the core of the problem stays the same and it makes it easier to understand: So lets say I create two classes, one for Apples and one for Bananas. Their attributes are basically the same (name, color and price).

I wanted to define a method for the banana class which iterates over a list of apples and check first whether the price of the banana is the same as for one of the apple objects. If that is the case, the banana should take over that apple's name (again, it doesnt make any sense in this code, but its relevant for the actual project I'm working on). In the second place, the method is supposed to check whether the banana has the same color as one of the apple objects and then take over that apples name (I used an elif statement for that one).

Now, whenever I try to run that code with the 3 Banana objects, Banana1 and 3 are assigned to the correct Apple,but Banana2 is assigned to Apple1 even though it should be assigned to Apple 2. I experimented a bit and found out that when I remove the break statement at the end of my elif condition which checks for the matching color all Bananas are assigned to the correct Apple. However, since I would like to set up another elif condition I cannot delete that break statement, right?
If anyone could help me to understand what is wrong with my code I would be very grateful. Sorry if there is an obvious solution for this problem, I'm very new to python programming. Thanks in advance for your help! Heres the full code:

class Apple:                                      
    def __init__(self, name, color, price):
        self.name = name
        self.color = color
        self.price = price

A1=Apple("Apple1", "red", 5)
A2=Apple("Apple2", "yellow", 3)
A3=Apple("Apple3", "green", 10 )

Apple_List=[A1, A2, A3]

class Banana:
    def __init__(self, name, color, price):
        self.name = name
        self.color = color
        self.price= price

    def evaluate(self):
        for a in Apple_List:
            if self.price==a.price:
                self.name=a.name
                break

            elif self.color==a.color:
                self.name=a.name
                break

        print(self.name)


B1=Banana("Banana1","yellow", 5)
B2=Banana("Banana2", "red", 3)
B3=Banana("Banana3", "green", 7)

B1.evaluate()
B2.evaluate()
B3.evaluate()

Thanks a lot for your answer metulburr! I figured out the problem thanks to your help. The tip of putting prints around each loop is a really good idea. Thumbs up!
metulburr likes this post
Quote

Top Page

Possibly Related Threads...
Thread Author Replies Views Last Post
  While loop doesn't end when False Kanashi 2 119 Nov-21-2019, 02:38 AM
Last Post: Kanashi
  why my function doesn't work cimerio 3 119 Nov-20-2019, 01:13 PM
Last Post: ChislaineWijdeven
  For loop in my __init__ doesn't work as expected Jessy 2 100 Nov-18-2019, 10:07 AM
Last Post: buran
  why does this if-statement not work? sandeen 2 78 Nov-15-2019, 03:17 PM
Last Post: sandeen
  Do break operators turn while loop conditions from True to False? Drone4four 5 242 Oct-24-2019, 07:11 PM
Last Post: newbieAuggie2019
  Problem with 'and' in 'if' statement CoderMan 3 160 Oct-06-2019, 07:32 PM
Last Post: buran
  Python: command “python -m pip install --upgrade pip” doesn't work apollo 2 281 Sep-16-2019, 03:11 PM
Last Post: snippsat
  problem with for loop using integers python_germ 5 275 Aug-31-2019, 11:42 AM
Last Post: jefsummers
  problem in loop roseojha 3 168 Aug-26-2019, 09:03 AM
Last Post: perfringo
Question Why does modifying a list in a for loop not seem to work? umut3806 2 268 Jul-22-2019, 08:25 PM
Last Post: umut3806

Forum Jump:


Users browsing this thread: 1 Guest(s)