my coding doesn't work plz help

[Darbandiman123]

so basically i am trying to make a piece of coding that asks what the person wants to do. however as you can see if you try my coding whenevr it says what do you want to do, no matter what the answer, it does calculator(). please help me. p.s. i havent yet added the coding for battleships() and tictactoe(). thanks

def calculator():
#returns the result of adding num1 + num2
    def add(num1, num2):
        return num1 + num2

#returns the result of subtracting num1 - num2
    def minus(num1, num2):
        return num1 - num2

#returns the result of mutipliying num1 * num2
    def multiply(num1, num2):
        return num1 * num2

#returns the result of dividing num1 / num2
    def divide(num1, num2):
        return num1 / num2



    operation = input("what do you want to do (+,-,*,/): ")
    if(operation != '+' and operation != '-' and operation != '*' and operation != '/'):
        #invalid operation
        print("please enter a vaild operation")
        calculator()
    else:
        num1 = int(input("Enter num1: "))
        num2 = int(input("Enter num2: "))
        if(operation == '+'):
            print(add(num1, num2))
            whattodo()
        elif(operation == '-'):
            print(minus(num1, num2))
            whattodo()
        elif(operation == '*'):
            print(multiply(num1, num2))
            whattodo()
        else:
            print(divide(num1, num2))
            whattodo()

def helloeveryone():

    useless = input('Hello, how are you?')
    myname = input("What is your name? ")
    print ('Nice to meet you, ' + myname)
    myage = input("What's your age, " + myname + "?")  #finds out name and age
    
def whattodo():
    function = input('So what do you want to do? Enter A for calculator, Enter B for Battleships and Enter C for tic tac toe. ')

    if(function == 'Access secret files'):
        secretfiles()
    elif (function == 'a' or 'A'):
        calculator()
    elif (function == 'b' or 'B'):
        battleships()
    elif (function == 'c' or 'C'):
        tictactoe()
    else:
        print ('no') 
            
def secretfiles():    
         print ('lol')       

helloeveryone()
whattodo()

[buran]

read this
https://python-forum.io/Thread-Multiple-...or-keyword

there are also other problems, but first fix this one.

[Darbandiman123]

ok done that :). what else is wrong

[wavic]

It is possible to define a function into another function but is pointless in your case. Rid of all these math functions which are doing one thing, to return a calculation result of two values. There is no indentation of elif to if

  if(operation == '+'):
      return num1 + num2
  elif(operation == '-'):
      return num1 - num2
  elif(operation == '*'):
      return num1 * num2
  else:
      return num1 / num2
......

print(calculator())

Also, you call calculator() inside its own code. Use while loop instead.
For now, that's all.

All in all, I'd have a different approach to almost everything.

[Ofnuts]

It is possible to define a function into another function but is pointless in your case. Rid of all these math functions which are doing one thing, to return a calculation result of two values. There is no indentation of elif to if

  if(operation == '+'):
      return num1 + num2
  elif(operation == '-'):
      return num1 - num2
  elif(operation == '*'):
      return num1 * num2
  else:
      return num1 / num2
......

print(calculator())

Also, you call calculator() inside its own code. Use while loop instead.
For now, that's all.

All in all, I'd have a different approach to almost everything.

On the contrary... Using functions is a good idea. You then use a dictionary where the keys are the operator strings and the value is the matching function:

ops={'+':add,'-':subtract,'*':multiply}

and use as:

result=ops[operator](num1,num2)

(python has built-in functions for the base operators (see the operators module), so you can even avoid defining some of the functions)

[wavic]

I am using this when I have many, many functions.

[Ofnuts]

I am using this when I have many, many functions.

You should start before that, for two reasons:

1. Code complexity (and test coverage) goes with the number of ifs...
   
2. One day you add a bunch of new functions and have to rewrite your code