[split] Python for Everybody 5.2 assignment

[jonchanzw]

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24

largest = None smallest = None while True:     num = input("Enter a number: ")     if num == "done":         break     try:         fnum = float(num)     except:         print("Invalid input")         continue     if largest is None :         largest = float(num)     elif num > largest :         largest = float(num)     if smallest is None :         smallest = float(num)     elif num < smallest :         smallest = float(num)     print(num)     print("Min:",smallest)     print("Max:",largest) print("Maximum is",int(largest)) print("Minimum is",int(smallest))

Can someone help point to where I have gone wrong with the logic please? Thanks!

[micseydel]

Can you be more specific? What inputs are you using? How exactly is the behavior different from what you want?

[nilamo]

elif num > largest :

num is a string. largest is a float. You have an fnum variable available, why not use that for comparisons?

[Arjun]

Here the code will help you...……
largest = None
smallest = None
while True:
try:
num = input("Enter the number: ")
if num == "done":
break
num = int(num)
if largest is None or largest < num:
largest = num
elif smallest is None or smallest > num:
smallest = num
except ValueError:
print("Invalid input")

print ("Maximum is", largest)
print ("Minimum is", smallest)

[perfringo]

As far as my googling went I understood that there are basically no limitations regarding solution.

So one can take advantage of Python 3.8 new cool feature and of course use built-in min and max to deliver result:

1 2 3 4 5 6 7 8 9

ints = []   while (answer := input('Enter integer: ').lower()) != 'done':     try:         ints.append(int(answer))     except ValueError:         print(f"{answer!r} can't be interpreted as integer")   print(f'Maximum entered value was {max(ints)} and minimum value was {min(ints)}')