Python Forum
Python Forum

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
why is it crushing ?
Cheetos
Unladen Swallow
Posts: 4
Threads: 1
Joined: Jan 2018
Reputation: 0
#1
Jan-26-2018, 01:29 PM (This post was last modified: Jan-26-2018, 01:29 PM by Cheetos.)
Hello guys i am totally new to python and programming at all
my first try was to make a simulator to the discord bot Tatsumaki fishing system but idk why is it keeps crushing
here is the code
import time
global coins
global common
global garbage
global uncommon
common = 0
uncommon = 0
garbage = 0
coins = 100
def start():
	print "Hello my friend!"
	name = raw_input("what's your name :")
	print "Welcome, "+ name + "!"
	print "This game is just like Tatsumaki Discord Bot fishing system, i hope that you enjoy it."
	print "the gole of the game is to collect as much fishs as possible then selling them for coins."
	print "Common fishs worth 12 coins/uncommon fishs worth 20 coins/garbage worth 8 coins."
	print "you have to pay 10 coins as a fee for fishing."

	choice = raw_input("Do you want to play Y/N ?:")
	if choice == "Y":
		print "To fish you have to use the command fish"
		begin()
	if choice == "N":
		print "Goodbye"
    	time.sleep(2)


def begin():
    global common
    global garbage
    global uncommon
    global coins  
    print "Let's start!"
    if coins > 500:
       print "You have won the game!"
       play = raw_input("Do you want to play again?:")
       if play == "Y":
          begin()
       if play == "N":
          print "Congrazts again"
          time.sleep(2)
    fish = raw_input("Do you want to fish ?:")
    if fish == "fish":
        print "You caught a common fish!"
        common=common+1
        coins=coins-10
        print "You currently have, "+common+"common fishs, "+uncommon+"uncommon fishs, "+garbage+"garbage fishs"
        print "your coins are now:"+coins
        begin()
    elif fish == "fish":
    	print "You caught an uncommon fish!"
        uncommon=uncommon+1
        coins=coins-10
        print "You currently have, "+common+"common fishs, "+uncommon+"uncommon fishs, "+garbage+"garbage fishs"
        print "your coins are now:"+coins
        begin()
    elif fish == "fish":
    	print "You caught a garbage fish!"
    	garbage=garbage+1
    	coins=coins-10
    	print "You currently have, "+common+"common fishs, "+uncommon+"uncommon fishs, "+garbage+"garbage fishs"
    	print "your coins are now:"+coins
    	begin()
    if fish == "N":
       sell = raw_input("Do you want to sell your fishs ? Y/N:")
       if sell == "Y":
          print "You currently have, "+common+"common fishs, "+uncommon+"uncommon fishs, "+garbage+"garbage fishs"
          print "You have sold your fishs."
          coins = common*12+uncommon*20+garbage*8
          common=0
          uncommon=0
          garbage=0
          print "your coins are now:"+coins
start()

it crushes when i get to this line 
 fish = raw_input("Do you want to fish ?:")
i hope if you can help and thanks
note i am used sublime to write the code and github to launch it.
Find
Reply
j.crater

Super Moderators
Posts: 1,150
Threads: 42
Joined: Sep 2016
Reputation: 46
#2
Jan-26-2018, 01:58 PM
Hello, please post full error traceback message in error code tags (red X icon next to Python code tags).

As an aside, it is highly recommended that you use Python 3 instead of P.2. Python 2 support is ending), Python 3 is the future.
Find
Reply
j.crater

Super Moderators
Posts: 1,150
Threads: 42
Joined: Sep 2016
Reputation: 46
#3
Jan-26-2018, 02:14 PM (This post was last modified: Jan-26-2018, 02:21 PM by j.crater.)
I modified your code to use in Python 3 and ran it. Namely raw_input() is input() in Python 3. And print is a function, not a statement, so you use it like print("This is printed!"). The code is:

import time

global coins
global common
global garbage
global uncommon
common = 0
uncommon = 0
garbage = 0
coins = 100


def start():
    print("Hello my friend!")
    name = input("what's your name :")
    print("Welcome, " + name + "!")
    print("This game is just like Tatsumaki Discord Bot fishing system, i hope that you enjoy it.")
    print("the gole of the game is to collect as much fishs as possible then selling them for coins.")
    print("Common fishs worth 12 coins/uncommon fishs worth 20 coins/garbage worth 8 coins.")
    print("you have to pay 10 coins as a fee for fishing.")

    choice = input("Do you want to play Y/N ?:")
    if choice == "Y":
        print("To fish you have to use the command fish")
        begin()
    if choice == "N":
        print("Goodbye")
        time.sleep(2)


def begin():
    global common
    global garbage
    global uncommon
    global coins
    print("Let's start!")
    if coins > 500:
        print("You have won the game!")
        play = input("Do you want to play again?:")
        if play == "Y":
            begin()
        if play == "N":
            print("Congrazts again")
            time.sleep(2)
    fish = input("Do you want to fish ?:")
    if fish == "fish":
        print("You caught a common fish!")
        common = common + 1
        coins = coins - 10
        print("You currently have, " + common + "common fishs, " + uncommon + "uncommon fishs, " + garbage + "garbage fishs")
        print("your coins are now:" + coins)
        begin()
    elif fish == "fish":
        print("You caught an uncommon fish!")
        uncommon = uncommon + 1
        coins = coins - 10
        print("You currently have, " + common + "common fishs, " + uncommon + "uncommon fishs, " + garbage + "garbage fishs")
        print("your coins are now:" + coins)
        begin()
    elif fish == "fish":
        print("You caught a garbage fish!")
        garbage = garbage + 1
        coins = coins - 10
        print("You currently have, " + common + "common fishs, " + uncommon + "uncommon fishs, " + garbage + "garbage fishs")
        print("your coins are now:" + coins)
        begin()
    if fish == "N":
        sell = input("Do you want to sell your fishs ? Y/N:")
        if sell == "Y":
            print("You currently have, " + common + "common fishs, " + uncommon + "uncommon fishs, " + garbage + "garbage fishs")
            print("You have sold your fishs.")
            coins = common * 12 + uncommon * 20 + garbage * 8
            common = 0
            uncommon = 0
            garbage = 0
            print("your coins are now:" + coins)


start()
I get an error with the print lines that print also variables, for example:
print("You currently have, " + common + "common fishs, " + uncommon + "uncommon fishs, " + garbage + "garbage fishs")
TypeError: Can't convert 'int' object to str implicitly
The variables you use in print are integers, while print can (at least directly) only take strings. So you need to convert them with str(), for example]:
str(common)
Find
Reply
Cheetos
Unladen Swallow
Posts: 4
Threads: 1
Joined: Jan 2018
Reputation: 0
#4
Jan-26-2018, 02:17 PM
(Jan-26-2018, 02:14 PM)j.crater Wrote: I modified your code to use in Python 3 and ran it. Namely raw_input() is input() in Python 3. And print is a function, not a statement, so you use it like print("This is printed!"). The code is:

import time

global coins
global common
global garbage
global uncommon
common = 0
uncommon = 0
garbage = 0
coins = 100


def start():
    print
    "Hello my friend!"
    name = input("what's your name :")
    print("Welcome, " + name + "!")
    print("This game is just like Tatsumaki Discord Bot fishing system, i hope that you enjoy it.")
    print("the gole of the game is to collect as much fishs as possible then selling them for coins.")
    print("Common fishs worth 12 coins/uncommon fishs worth 20 coins/garbage worth 8 coins.")
    print("you have to pay 10 coins as a fee for fishing.")

    choice = input("Do you want to play Y/N ?:")
    if choice == "Y":
        print("To fish you have to use the command fish")
        begin()
    if choice == "N":
        print("Goodbye")
        time.sleep(2)


def begin():
    global common
    global garbage
    global uncommon
    global coins
    print("Let's start!")
    if coins > 500:
        print("You have won the game!")
        play = input("Do you want to play again?:")
        if play == "Y":
            begin()
        if play == "N":
            print("Congrazts again")
            time.sleep(2)
    fish = input("Do you want to fish ?:")
    if fish == "fish":
        print("You caught a common fish!")
        common = common + 1
        coins = coins - 10
        print("You currently have, " + common + "common fishs, " + uncommon + "uncommon fishs, " + garbage + "garbage fishs")
        print("your coins are now:" + coins)
        begin()
    elif fish == "fish":
        print("You caught an uncommon fish!")
        uncommon = uncommon + 1
        coins = coins - 10
        print("You currently have, " + common + "common fishs, " + uncommon + "uncommon fishs, " + garbage + "garbage fishs")
        print("your coins are now:" + coins)
        begin()
    elif fish == "fish":
        print("You caught a garbage fish!")
        garbage = garbage + 1
        coins = coins - 10
        print("You currently have, " + common + "common fishs, " + uncommon + "uncommon fishs, " + garbage + "garbage fishs")
        print("your coins are now:" + coins)
        begin()
    if fish == "N":
        sell = input("Do you want to sell your fishs ? Y/N:")
        if sell == "Y":
            print("You currently have, " + common + "common fishs, " + uncommon + "uncommon fishs, " + garbage + "garbage fishs")
            print("You have sold your fishs.")
            coins = common * 12 + uncommon * 20 + garbage * 8
            common = 0
            uncommon = 0
            garbage = 0
            print("your coins are now:" + coins)


start()
I get an error with the print lines that print also variables, for example:
print("You currently have, " + common + "common fishs, " + uncommon + "uncommon fishs, " + garbage + "garbage fishs")
TypeError: Can't convert 'int' object to str implicitly
The variables you use in print are integers, while print can (at least directly) only take strings. So you need to convert them with [i]str()[/i, for example]:
str(common)

gonna install python 3 and about the error i am not getting any error it crushes when i tybe fish in the program
Find
Reply
j.crater

Super Moderators
Posts: 1,150
Threads: 42
Joined: Sep 2016
Reputation: 46
#5
Jan-26-2018, 02:25 PM
Hmmm alright, that is strange. How are you running your code? I searched a bit and some people have had troubles with IDLE and raw_input.
Find
Reply
Cheetos
Unladen Swallow
Posts: 4
Threads: 1
Joined: Jan 2018
Reputation: 0
#6
Jan-26-2018, 02:33 PM (This post was last modified: Jan-26-2018, 02:37 PM by Cheetos.)
(Jan-26-2018, 02:25 PM)j.crater Wrote: Hmmm alright, that is strange. How are you running your code? I searched a bit and some people have had troubles with IDLE and raw_input.

i am running it like like that
from the command line
cd desktop then start python test.py
when i try to launch it from the IDLE i get this massage
Hide/Show
Find
Reply
sparkz_alot
Da Bishop

 Team Member
Posts: 1,298
Threads: 38
Joined: Sep 2016
Reputation: 30
#7
Jan-26-2018, 03:59 PM
I've modified j.crater's code (the 'print' functions) so no conversion is necessary (still in Python 3)

Hide/Show
Your other problem, is your initial "if" statement if fish == "fish": will always evaluate as true, so none of the "elif's" will be looked at. You could create a list of options, say choices = ['common', 'uncommon', 'garbage'] then randomly select one of those (Hint: Random), you could then have:
if choices == 'common':
    do something
elif choices == 'uncommon':
    do something
elif choices == 'garbage':
    do something
Another problem, is I can fish myself into debt as you have made no action to be taken if I reach 0 coins.

There are other smaller items that could be addressed, but I think you'll be fine if you handle the big problems first.

As to the error you are receiving, it's because in your code you've used both tabs and spaces for indentation. In Python, you should always use 4 spaces for indentation

And yes, by all means switch to Python 3 (3.6.4 if possible)
If it ain't broke, I just haven't gotten to it yet.
OS: Windows 10, openSuse 42.3, freeBSD 11, Raspian "Stretch"
Python 3.6.5, IDE: PyCharm 2018 Community Edition
Find
Reply
league55
Not Blown Up Yet
Posts: 70
Threads: 23
Joined: Jan 2018
Reputation: 0
#8
Jan-26-2018, 05:34 PM (This post was last modified: Jan-26-2018, 05:35 PM by league55.)
IDLE should have a Settings option under Edit (at the top) where you can set it to always insert spaces instead of tabs and set the number of spaces it inserts (the Python standard is 4 spaces).
Find
Reply
Cheetos
Unladen Swallow
Posts: 4
Threads: 1
Joined: Jan 2018
Reputation: 0
#9
Jan-26-2018, 05:47 PM
(Jan-26-2018, 03:59 PM)sparkz_alot Wrote: I've modified j.crater's code (the 'print' functions) so no conversion is necessary (still in Python 3)

Hide/Show
Your other problem, is your initial "if" statement if fish == "fish": will always evaluate as true, so none of the "elif's" will be looked at. You could create a list of options, say choices = ['common', 'uncommon', 'garbage'] then randomly select one of those (Hint: Random), you could then have:
if choices == 'common':
    do something
elif choices == 'uncommon':
    do something
elif choices == 'garbage':
    do something
Another problem, is I can fish myself into debt as you have made no action to be taken if I reach 0 coins.

There are other smaller items that could be addressed, but I think you'll be fine if you handle the big problems first.

As to the error you are receiving, it's because in your code you've used both tabs and spaces for indentation. In Python, you should always use 4 spaces for indentation

And yes, by all means switch to Python 3 (3.6.4 if possible)
thanks very much it's working great now gonna do what you said about choice atm
Find
Reply
mepyyeti
Wafer-Thin Wafer
Posts: 83
Threads: 33
Joined: Dec 2017
Reputation: 1
#10
Jan-26-2018, 06:17 PM (This post was last modified: Jan-26-2018, 06:17 PM by mepyyeti.)
(Jan-26-2018, 03:59 PM)sparkz_alot Wrote: I've modified j.crater's code (the 'print' functions) so no conversion is necessary (still in Python 3)

Hide/Show
Your other problem, is your initial "if" statement if fish == "fish": will always evaluate as true, so none of the "elif's" will be looked at. You could create a list of options, say choices = ['common', 'uncommon', 'garbage'] then randomly select one of those (Hint: Random), you could then have:
if choices == 'common':
    do something
elif choices == 'uncommon':
    do something
elif choices == 'garbage':
    do something
Another problem, is I can fish myself into debt as you have made no action to be taken if I reach 0 coins.

There are other smaller items that could be addressed, but I think you'll be fine if you handle the big problems first.

As to the error you are receiving, it's because in your code you've used both tabs and spaces for indentation. In Python, you should always use 4 spaces for indentation

And yes, by all means switch to Python 3 (3.6.4 if possible)

Curious: 1) why are the variables being declared as global twice? Wouldn't declaring them (common,coins,etc) global in in begin() suffice?

2) what's the benefit of ''.format(int) over concatenating str(int) as in the case of
Find
Reply


Forum Jump:

User Panel Messages

Log Out
My Profile
Pay your profile a visit
User Control Panel
Do some changes on your profile
My Messages
View private messages unread
Avatar
Change avatar
Signature
Change signature
Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020