Quote: def drawWeap(self, i):
gearBool = i.itemReturn()
if self.direct == 'Left':
if gearBool['armor'] == None:
self.character = gD.blit(Character[3], (self.x, self.y))
if gearBool['armor'] != None:
self.character = gD.blit(Character[3], (self.x, self.y))
self.armor = gD.blit(self.color[3], (self.x, self.y))
if gearBool['weapon'] != None:
self.weapon = gD.blit(self.weapType[3], (self.x - round(self.width*.8), self.y + round(self.height/2)))
if and elif, not only if. Secondly you should split the logic of armor and weapons from the draw method. This alone would reduce the number of lines in your code as well make your code much more readable to new people looking at it. If you copy and paste a lot of code, then you are doing something wrong. And you are doing that. def move(self, p):
if not self.dead:
plrPos = p.getPos()
plrX = plrPos[0]
plrY = plrPos[1]
self.collision(p)
DownRight = ['Down', 'Right']
UpRight = ['Right', 'Up']
UpLeft = ['Up', 'Left']
DownLeft = ['Down', 'Left']
AnyDirect = ['Down', 'Up', 'Left', 'Right']
if plrX > self.x and plrY > self.y:
self.x += .2
self.y += .2
if self.diff == 'noob':
num = random.randint(1, 200)
elif self.diff == 'easy':
num = random.randint(1, 100)
if num < 3:
self.direct = random.choice(DownRight)
elif plrX > self.x and plrY < self.y:
if self.diff == 'noob':
num = random.randint(1, 200)
elif self.diff == 'easy':
num = random.randint(1, 100)
if num < 3:
self.direct = random.choice(UpRight)
self.x += .2
self.y -= .2
elif plrX < self.x and plrY < self.y:
if self.diff == 'noob':
num = random.randint(1, 200)
elif self.diff == 'easy':
num = random.randint(1, 100)
if num < 3:
self.direct = random.choice(UpLeft)
self.x -= .2
self.y -= .2
elif plrX < self.x and plrY > self.y:
if self.diff == 'noob':
num = random.randint(1, 200)
elif self.diff == 'easy':
num = random.randint(1, 100)
if num < 3:
self.direct = random.choice(DownLeft)
self.x -= .2
self.y += .2
elif plrX == self.x and plrY > self.y:
if self.diff == 'noob':
num = random.randint(1, 200)
elif self.diff == 'easy':
num = random.randint(1, 100)
if num < 3:
self.direct = 'Down'
self.y += .2
elif plrX == self.x and plrY < self.y:
if self.diff == 'noob':
num = random.randint(1, 200)
elif self.diff == 'easy':
num = random.randint(1, 100)
if num < 3:
self.direct = 'Up'
self.y -= .2
elif plrY == self.y and plrX > self.x:
if self.diff == 'noob':
num = random.randint(1, 200)
elif self.diff == 'easy':
num = random.randint(1, 100)
if num < 3:
self.direct = 'Right'
self.x += .2
elif plrY == self.y and plrX < self.x:
if self.diff == 'noob':
num = random.randint(1, 200)
elif self.diff == 'easy':
num = random.randint(1, 100)
if num < 3:
self.direct = 'Left'
self.x -= .2
elif plrX == self.x and plrY == self.y:
if self.diff == 'noob':
num = random.randint(1, 200)
elif self.diff == 'easy':
num = random.randint(1, 100)
if num < 3:
self.direct = random.choice(AnyDirect) if self.direct == 'Left':
WeapRect = self.weapType[3]
WeapRect = WeapRect.get_rect()
WeapRect[0] = self.rect[0] - round(self.width*.8)
WeapRect[1] = self.rect[1] + round(self.height/2)
elif self.direct == 'Right':
WeapRect = self.weapType[1]
WeapRect = WeapRect.get_rect()
WeapRect[0] = self.rect[0] + round(self.width*.8)
WeapRect[1] = self.rect[1] + round(self.height/2)
elif self.direct == 'Up':
WeapRect = self.weapType[0]
WeapRect = WeapRect.get_rect()
WeapRect[0] = self.rect[0] + round(self.width/2)
WeapRect[1] = self.rect[1] - round(self.height*.8)
elif self.direct == 'Down':
WeapRect = self.weapType[2]
WeapRect = WeapRect.get_rect()
WeapRect[0] = self.rect[0] + round(self.width/2)
WeapRect[1] = self.rect[1] + round(self.height*.8)You are copying code to apply to each direction. With dictionaries, you can do this once instead of copy and pasting for each direction. You do this quite often everywhere. Which would reduce your code by 75%.