Python Forum

So I wrote some code and it works fine but I am having issues passing in classes/functions from the command line.

Here's the code:

import sys
import netmiko
import json

from Hardware_info import HardwareMaintenance

Hardware = HardwareMaintenance.hardware_handler


class Connect:
    def __init__(self, **kwargs):
        # self.protocol = netmiko.ssh_autodetect
        # pass
        intake_file = open('ip_list.txt', 'r')
        self.json_data = [json.loads(line) for line in intake_file]
        self.kwargs = [Hardware]

    def connect_parser(self, kwargs=None):

        for data in self.json_data:
            ip = data["ip"]
            # port = data["port"]
            username = data["username"] if data["username"] else ""
            password = data["password"] if data["password"] else ""
            secret = data["secret"] if "secret" in data else False
            device_type = data["device_type"] if data["device_type"] else ""

            if data["header"] == "Netmiko":
                print("The variables being passed:  " + ip, username, password, device_type)
                ConnectHandler = netmiko.ConnectHandler(
                    device_type=device_type,
                    host=ip,
                    username=username,
                    password=password,
                    port=22,
                    secret=data["secret"] if "secret" in data else False
                )
                ConnectHandler.enable()

when I add this line next under ConnectHandler.enable() it works:
Hardware(ConnectHandler,ip)

Hardware is another class which reads in ip from the above code and performs some operations.
Everything is working fine.

Now I want to try to call Hardware from the cli, as I will be having up to 5-10 seperate classes that will be performing operations on ConnectHandler and ip, i.e class_n(ConnectHandler, ip)

and I want to pick and choose classes from the cli.


And so I did this:

if __name__ == "__main__":
    from Connect_Handler import Hardware
    from Connect_Handler import Connect
    Connector = Connect()
    inlist = sys.argv[0]
    Connector.connect_parser(inlist)

I also added this into the main script under ConnectHandler.enable()

 for i in kwargs:
                    i(ConnectHandler)

where kwargs are variables to be passed into connect_parser

notice how I imported Hardware above. I am ok with that, that isn't the problem, as i will be importing multiple classes whether here or in the main.py file, and I want to define which classes to use in a list in the command line. Hardware is a class. It work fine when I executed it in the Connect class.


here's me trying to execute it from the CLI:


py Connect_Handler.py inlist = [Hardware]

notice i passed in inlist as sysargv, and I want it to operate like kwargs in connect_parser.

The output gives me 'str' object is not callable


so then i change the name == __main__ section to:

if __name__ == "__main__":
    from Connect_Handler import Hardware
    from Connect_Handler import Connect
    Connector = Connect()
    inlist = sys.argv[0]
    for i in inlist:
        i(Connector.connect_parser())

again it gives me 'str' object is not callable



and so i tried this, and printed out the 'type' of my functions to have a look at them, and realised that Connector.connect_parser() resolves to a NoneType:

if __name__ == "__main__":
    from Connect_Handler import Hardware
    from Connect_Handler import Connect
    Connector = Connect().connect_parser()
    print(Connector)
    inlist = sys.argv[0]
    Connector.Connect(inlist)

CLI:
py Connect_Handler.py [Hardware]


and it gives me
"NoneType has no attribute Connect"




Can some one guide me either to what to do or where to experiment to try and resolve this issue? In the end all I need to do is call Hardware on the ConnectHandler from the CLI

Hardware(ConnectHandler)

by passing it to connect_parser
connect_parser(Hardware)

as I plan on passing a list of imported functions from the CLI when i run this.

I tried to define the sys.argv within the class itself, and I still get TypeError 'str' object is not callable.

import sys
import netmiko
import json

from Hardware_info import HardwareMaintenance

Hardware = HardwareMaintenance.hardware_handler


class Connect:
    def __init__(self, **kwargs):
        # self.protocol = netmiko.ssh_autodetect
        # pass
        intake_file = open('ip_list.txt', 'r')
        self.json_data = [json.loads(line) for line in intake_file]
        self.kwargs = [Hardware]

    def connect_parser(self, inlist=[]):
        inlist = sys.argv[0]
        for data in self.json_data:
            ip = data["ip"]
            # port = data["port"]
            username = data["username"] if data["username"] else ""
            password = data["password"] if data["password"] else ""
            secret = data["secret"] if "secret" in data else False
            device_type = data["device_type"] if data["device_type"] else ""

            if data["header"] == "Netmiko":
                print("The variables being passed:  " + ip, username, password, device_type)
                ConnectHandler = netmiko.ConnectHandler(
                    device_type=device_type,
                    host=ip,
                    username=username,
                    password=password,
                    port=22,
                    secret=data["secret"] if "secret" in data else False
                )
                ConnectHandler.enable()
                for i in inlist:
                    i(ConnectHandler,ip)

if __name__ == "__main__":
    from Connect_Handler import Hardware
    from Connect_Handler import Connect
    print(Connect().connect_parser())
    inlist = sys.argv[0]
    #Connector.Connect(inlist)

# def runner():
#    #for i in sys.argv[0]:
#   Hardware(Connector.)
# runner()

notice I added

                for i in inlist:
                    i(ConnectHandler,ip)

to the end under ConnectHandler.enable()

and it's giving me the TypeError 'str' object is not callable
whether or not I pass in a list for sys.argv[0] in the command line.



however when I change inlist to:

    def connect_parser(self, inlist=[]):
        inlist = [Hardware]

notice i included Hardware


and now it is working fine. I don't want to be able to do this by passing in a list in the CLI...

I tried

    def connect_parser(self, inlist=[]):
        inlist = sys.argv[0]

and no go

I read online the command list in windows reads everything in as a string.
So I changed my __name__ == __main__ to below and it works, as I had to sstrip and split the argument into a list and map it back to a dictionary which stored functions.

I'm sure there's ways to make the code more precise, maybe using a map function, but it is working now.

functions = {'Hardware': Hardware}


if __name__ == "__main__":
    from Connect_Handler import Hardware
    from Connect_Handler import Connect
    inlist = sys.argv[1]
    outlist = inlist.strip("[]").split(",")
    inlist = []
    Connector = Connect()
    for i in outlist:
        inlist.append(functions[i])
    Connector.connect_parser(inlist)

Better use the arparse module from the standard library to handle CLI arguments

import argparse

class Hardware:
    pass
class Spam:
    pass
class Eggs:
    pass

if __name__ == '__main__':
    functions = {'Hardware': Hardware,
                 'Spam': Spam,
                 'Eggs': Eggs}

    parser = argparse.ArgumentParser()
    parser.add_argument(
        '--connect', '-c',
        choices=functions.values(),
        nargs='*',
        action='extend',
        dest='inlist',
        type=functions.get)
    ns = parser.parse_args()
    print(ns.inlist)
    for f in ns.inlist:
        f()

Output:
$ python paillasse/pf/billy.py -c Hardware Eggs
[<class '__main__.Hardware'>, <class '__main__.Eggs'>]