Simple password generator using a module I made myself - Printable Version +- Python Forum (https://python-forum.io) +-- Forum: General (https://python-forum.io/forum-1.html) +--- Forum: Code Review (https://python-forum.io/forum-46.html) +--- Thread: Simple password generator using a module I made myself (/thread-28867.html) |
Simple password generator using a module I made myself - Fr4nkl1n_1k3h - Aug-06-2020 Hello guys this is my first post. Here's the link to the code: https://github.com/fr4nkl1n-1k3h/Password_Generator RE: Simple password generator using a module I made myself - scidam - Aug-07-2020 I looked on your code and would say the following: 1) If I typed desired password length, e.g. 2, I would get a password of len 4. This slightly confuses. You need to note somewhere in docs, that program generates passwords longer 4 symbols only. 2) You defined ALPHABET and other auxiliary strings; however, these strings already defined in string module. You could just import them.3) Program implementation guarantees that the first 4 symbols of a password came from 4 different classes (lowercase, uppercase, numbers, punctuation). However, other symbols are generated randomly: In rc.all you generated 4 symbols from these classes and then chose one of them. This is totally equivalent to choosing one symbol from the entire set of symbols (lowercase+uppercase+nums+puncts).
RE: Simple password generator using a module I made myself - Fr4nkl1n_1k3h - Aug-07-2020 (Aug-07-2020, 12:33 AM)scidam Wrote: I looked on your code and would say the following:Thanks alot for your review, I didn't think about those, I'll start working on those RE: Simple password generator using a module I made myself - Fr4nkl1n_1k3h - Aug-07-2020 I've corrected them, once again thanks for the review |