(Aug-12-2020, 05:56 PM)fatherted99 Wrote: When I am reading user credentials from an external file and into a list, I need to get rid of certain characters.
I know how to do this that is simple, its just for example I need to get rid of the character " ' " because extra characters are present/added on when reading from a file.

def Create_account_function():
    
    create_account_new_USERNAME = False
   

 # I used 'r' to make the string a raw string, because sometimes pythond doesnt like a file path as a normal string, so I do this to prevent it crashing
    Create_file = open(r"A_file_path.txt", 'a')
    Create_file.write("")
    Create_file.close()

    Read_credentials = [] # this is a list to store data from an external file

    with open(r"A_file_path.txt", 'r') as PlayerCredentials_File: # open the file containing the user credentials
        for line in PlayerCredentials_File: # iterate through each line in the file
            Read_credentials.append(line.strip('\n')) # store credentials in a list

    while create_account_new_USERNAME == False: # Do until the username is unique and correct length
        
        
                    
        def user_name_check():
           
            create_account_credentials_LENGTH = False
            while create_account_credentials_LENGTH == False: # Do until the length of usernames and passwords is correct

                # User will input a username and a password which has certain character length requirements
                name = str(input("Enter a username(MUST BE AT LEAST 5 CHARACTERS LONG): "))
                password = str(input("Enter a password(MUST BE AT LEAST 8 CHARACTERS LONG): "))
            
                    
                # checks if the length of the name and password are correct and valid.
                if len(name) < 5:
                    print("Your username and/or password must be at least 5 characters for the username and 8 characters long for the password")
                elif len(password) < 8:
                    print("Your username and/or password must be at least 5 characters for the username and 8 characters long for the password")
                else:
                    print("Your username and password are at the correct length")
                    create_account_credentials_LENGTH = True # the length of usernames and passwords are now correct

            for list_length_index in range(0, len(Read_credentials)):
                
                if Read_credentials[list_length_index] == name: # if the current item in the list == the name, then the name has been already taken, so call a function to make a new username
                    print("This username has already been taken, please choose a new username (sad face)")
                    user_name_check()
                elif list_length_index + 1 == len(Read_credentials): # you have iterated through all the items in the list, meaning that the username is unique, break so we can upload details to external file.
                    print("This username has NOT been taken, this is now your username! (happy face)")
                    break
                else:
                    pass # the item did not equal the username, and we are not at the end of the list yet. Keep looping

            Player_credentials =  [name, password]
            with open(r"A_file_path.txt", 'a') as PlayerCredentials_File:
                print(Player_credentials, file=PlayerCredentials_File)  # your password is above 8 characters, your username is unique, write that to a file.
   

            


        create_account_new_USERNAME = True
        user_name_check()
         




Create_account_function()

(Aug-12-2020, 06:41 PM)fatherted99 Wrote: Format in which username and password is stored in a .txt file

['username', 'password']

(Aug-12-2020, 06:40 PM)jefsummers Wrote: A few things to get you started. Typically you will not create a function within a function, as you have here. You are also creating the function inside a while loop - although probably only run once, that leaves you with potentially defining the function multiple times.

You also have scope issues. Each function has its own namespace - variables within that function are visible only to things inside that function. And, the main script also has its namespace. So, the variables inside user_name_check() are not visible to Create_account_function(). Instead, you should pass the variables needed to each function and have that function return a result.

Need to fix those before you get too far into removing individual characters.

(Aug-12-2020, 06:59 PM)buran Wrote: split your code in chunks, that do small, but complete steps, e.g.
take user input and validate it for length
read the file content
check user input against current file content
write valid username and password to the file

at the moment you print to a file a list. that is why you get extra brackets, comma and quotes.
read how to write to a file, e.g. in following format:
username,password

given that it's a school assignment, a different format like JSON maybe more easy to handle and check against

lines 7-9 in current code are redundant. why do you have them

            with open(r"some file path.txt", 'a') as PlayerCredentials_File:
                print(f'{name}, {password}', file=PlayerCredentials_File)  # your password is above 8 characters, your username is unique, write that to a file.