Python Forum
GUI application - code review - Printable Version

+- Python Forum (https://python-forum.io)
+-- Forum: General (https://python-forum.io/forum-1.html)
+--- Forum: Code Review (https://python-forum.io/forum-46.html)
+--- Thread: GUI application - code review (/thread-41361.html)

GUI application - code review - Sr999 - Jan-01-2024

Hello guys , i have been learning python for like 1.5 month last time i got here nice reviews and aspects of my code progress and i would like to get another review
my progress is kind of slow cause im learning in my free time and still has a full time job but i would like to hear anyone tips and thoughts about my code in order for me to improve faster.
this is my last project an app to learn language with all data as taken from the internet and translated by google translate to different language so it may not be accurate to all languages but the main idea is the code and not the correction of the data in the program
feel free to write your thoughts

https://github.com/SeanR11/Pylang

**
in your review please try include this elements:
- code readability
- code efficiency



________________________________________
this is my last code review if you want ot check and have any notes to add there: https://python-forum.io/thread-41202.html

RE: GUI application - code review - Axel_Erfurt - Jan-01-2024

You should add a README with a description on github.

RE: GUI application - code review - Axel_Erfurt - Jan-01-2024 

Output:
Traceback (most recent call last):
  File "/tmp/Pylang/MainWindow.py", line 6, in <module>
    from ContinueLearnFrame import ContinueLearnFrame
  File "/tmp/Pylang/ContinueLearnFrame.py", line 156
    self.cards[0].itemconfigure('word', text=f'{self.words['learned']}')
                                                            ^^^^^^^
SyntaxError: f-string: unmatched '['
change it to

                        self.cards[0].itemconfigure('word', text=f'{self.words["learned"]}')
                        self.cards[1].itemconfigure('word', text=f'{self.words["native"]}')


RE: GUI application - code review - Sr999 - Jan-06-2024

(Jan-01-2024, 08:50 PM)Axel_Erfurt Wrote: 
Output:
Traceback (most recent call last):
  File "/tmp/Pylang/MainWindow.py", line 6, in <module>
    from ContinueLearnFrame import ContinueLearnFrame
  File "/tmp/Pylang/ContinueLearnFrame.py", line 156
    self.cards[0].itemconfigure('word', text=f'{self.words['learned']}')
                                                            ^^^^^^^
SyntaxError: f-string: unmatched '['
change it to

                        self.cards[0].itemconfigure('word', text=f'{self.words["learned"]}')
                        self.cards[1].itemconfigure('word', text=f'{self.words["native"]}')

didnt get those errors on my runs but indeed it may cause problems i have changed it thanks for the notes if u have any more thoughts i will glad to hear them