class frame:
    def __init__(self, width, height):
        self.frame_width = width
        self.frame_height = height

    def image(self):
         self.width = 0.8 * self.frame_width
         self.height = 0.8 * self.frame_height

picture = frame(60,40)

picture.image.width

class Frame:
    def __init__(self, width, height):
        self.frame_width = width
        self.frame_height = height
        
    @property
    def image_width(self):
        return 0.8 * self.frame_width

    @property
    def image_height(self):
        return 0.8 * self.frame_height


picture = Frame(100, 200)
print(f'Frame: {picture.frame_width}X{picture.frame_height}, picture:{picture.image_width}X{picture.image_height}')

(Apr-11-2025, 07:29 AM)buran Wrote: I will start with more general remarks. It is convention that class name should start with capital letter, so better use Frame, not frame. Then it looks like you actually want image to be a class on its own (i.e. the image inside the frame), right? At the moment it's a method of class Frame. If it would not be a class on its own, then width and height would be properties of the frame And probably you want them to be fixed as proportion to frame size, so use @property decorator

class Frame:
    def __init__(self, width, height):
        self.frame_width = width
        self.frame_height = height
        
    @property
    def image_width(self):
        return 0.8 * self.frame_width

    @property
    def image_height(self):
        return 0.8 * self.frame_height


picture = Frame(100, 200)
print(f'Frame: {picture.frame_width}X{picture.frame_height}, picture:{picture.image_width}X{picture.image_height}')

class frame:
    
    def __init__(self, width, height):
        p = 0.8
        self.width = width
        self.height = height
        self.image = image(self.width, self.height, p) 
 
class image:
    def __init__(self, width, height, p):     
        self.width  = p * width
        self.height = p * height

 
picture = frame(60,40)
print(picture.image.width)
48.0
print(picture.width)
60

class Frame:
     
    def __init__(self, width, height):
        p = 0.8
        self.width = width
        self.height = height
        self.image = Image(self.width * p, self.height * p) 
  
class Image:
    def __init__(self, width, height):     
        self.width  = width
        self.height = height

class ImageFrame:

    PROPORTIONALITY = 0.8

    def __init__(self, width, height):
        self.width = width
        self.height = height
        self.image = Image(self.width * self.PROPORTIONALITY, self.height * self.PROPORTIONALITY) 

class ImageFrame:

    def __init__(self, width, height, proportionality=0.8):
        self.width = width
        self.height = height
        self.image = Image(self.width * proportionality, self.height *proportionality) 

(Apr-11-2025, 07:41 PM)deanhystad Wrote: I think it makes a lot more sense to do this:

class Frame:
     
    def __init__(self, width, height):
        p = 0.8
        self.width = width
        self.height = height
        self.image = Image(self.width * p, self.height * p) 
  
class Image:
    def __init__(self, width, height):     
        self.width  = width
        self.height = height

Having width as an argument to Image.__init__ and as an attribute, it is weird that the two values would not match immediately after an instance is created.

Now is a good time to start following python coding conventions. Class names start with an uppercase letter. This makes it easy to tell the difference between creatin an instance of a class and calling a function.

p is an odd thing. There are multiple ways that p can be handled. You could make p a class attribute.

class ImageFrame:

    PROPORTIONALITY = 0.8

    def __init__(self, width, height):
        self.width = width
        self.height = height
        self.image = Image(self.width * self.PROPORTIONALITY, self.height * self.PROPORTIONALITY) 

An advantage with this is code can ask the ImageFrame (a better name than Frame for a Frame that's defining attribute is it contains an image) what is the value of the proportionality constant. It also makes the proportionality constant stand out. If you later decide that the images should be 90% as big as the frame, it is easy to find where proportionality is set.

You could make p an argument in the init method. If you want p to be 0.8 most of the time, you can set a default value.

class ImageFrame:

    def __init__(self, width, height, proportionality=0.8):
        self.width = width
        self.height = height
        self.image = Image(self.width * proportionality, self.height *proportionality) 

An advantage to this approach is you can make different image frames with different p values.

class Frame:
    
    def __init__(self, width, height, factor):
        self.frame_width = width
        self.frame_height = height
        self.factor = factor
 
    def image(self):         
         return (self.frame_width * self.factor, self.frame_height * self.factor)

Picture = Frame(60,40,0.8)
tup = Picture.image() # returns (48.0, 32.0)

(Apr-12-2025, 12:59 AM)Abedin Wrote: I like the solution and this was what I was looking for. I will implement that into my code.