Python Forum
Can anyone make sense of this?
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Can anyone make sense of this?
#7
(Apr-19-2020, 10:45 AM)steve_shambles Wrote: Do I now submit a "pull request" so that the author can update the package?

Normally - yes, you can make a pull request and maintainer can review and merge your pull request.

Given their comment this is quick-and_dirty patch and that they don't have time to implement it properly as well as they provide you with diff file (i.e. they probably made the change locally, and produce the diff file, but didn't push to remote) they will probably not accept and merge your pull request. If they wanted, they can push their own change. Note there are 3 pull requests (of which 2 are 2-years old and they are neither merged nor rejected.)
If you can't explain it to a six year old, you don't understand it yourself, Albert Einstein
How to Ask Questions The Smart Way: link and another link
Create MCV example
Debug small programs

Reply


Messages In This Thread
Can anyone make sense of this? - by steve_shambles - Apr-19-2020, 05:19 AM
RE: Can anyone make sense of this? - by bowlofred - Apr-19-2020, 05:36 AM
RE: Can anyone make sense of this? - by ndc85430 - Apr-19-2020, 05:59 AM
RE: Can anyone make sense of this? - by buran - Apr-19-2020, 11:21 AM

Possibly Related Threads…
Thread Author Replies Views Last Post
  Re writing poste to make sense please help me Nearrivers 10 7,406 Apr-02-2018, 11:52 PM
Last Post: Nearrivers
  These boolean statements don't make sense? Athenaeum 6 6,279 Oct-03-2017, 03:34 AM
Last Post: Larz60+

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020