Python Forum
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Connect 4 assigment
#10
This part of the code is pretty horrible:
    if turn == 0:   
        col = int(input('Player 1 make your Selection (0-6)'))
 
        if is_valid_location(board, col):
            row = get_next_open_row(board, col)
            drop_piece(board, row, col, 1)
             
            if winning_move(board, 1):
                print('Player 1 win !!')
                game_over = True
    # Ask for player 2 input
 
    else:
        col = int(input('Player 2 make your Selection (0-6)'))
 
        if is_valid_location(board, col):
            row = get_next_open_row(board, col)
            drop_piece(board, row, col, 2)
 
            if winning_move(board, 1):
                print("Player 1 wins !!")
                game_over = True
Do you notice anything about this code? Anything, repetitive? Like the code for the first player and the second player being identical except the first player is "1" and the second player is "2"? Do you think you could improve upon this code by removing all the duplicate code and make a more generic coding that works for both player 1 and player 2? At least then you wouldn't be blatantly plagiarizing if you turned this in.
Reply


Messages In This Thread
Connect 4 assigment - by Milan - Jan-13-2021, 02:21 PM
RE: Connect 4 assigment - by jefsummers - Jan-13-2021, 05:47 PM
RE: Connect 4 assigment - by DPaul - Jan-14-2021, 07:31 AM
RE: Connect 4 assigment - by Milan - Jan-14-2021, 02:29 PM
RE: Connect 4 assigment - by DPaul - Jan-14-2021, 04:12 PM
RE: Connect 4 assigment - by deanhystad - Jan-14-2021, 07:48 PM
RE: Connect 4 assigment - by Milan - Jan-15-2021, 05:08 PM
RE: Connect 4 assigment - by deanhystad - Jan-16-2021, 05:23 AM
RE: Connect 4 assigment - by Milan - Jan-20-2021, 10:02 PM
RE: Connect 4 assigment - by deanhystad - Jan-20-2021, 10:37 PM
RE: Connect 4 assigment - by deanhystad - Jan-22-2021, 05:06 AM

Possibly Related Threads…
Thread Author Replies Views Last Post
  Sorting list - Homework assigment ranbarr 1 2,335 May-16-2021, 04:45 PM
Last Post: Yoriz
  Python homework assigment makisha 3 3,419 Feb-28-2019, 10:21 PM
Last Post: Yoriz
  Display school assigment Vittya 2 3,610 Nov-09-2017, 02:13 PM
Last Post: sparkz_alot

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020