Jul-27-2021, 08:54 AM
(Jul-26-2021, 02:34 PM)deanhystad Wrote: Your main problem is that your code is a mess. You use global variables for passing information in and out of functions and you use recursion when you want to repeat code. That is always going to make bad code no matter what the underlying algorithm.
Your first step should be to eliminate all recursive function calls. Recursion has it's uses, but none of them are what you are using recursion for. If you want to input multiple items, use a loop. If you want to ask for information until the information is correct, use a loop. If you ever want to use recursion, use a loop. Maybe that last bit of advice is too harsh, but barely.
Your second step should be to eliminate all the global variables. Global variables make it too hard to write correct code. The main benefit of functions is they break code into little pieces. If each piece works, and you use the pieces correctly the program works (usually). If your functions use global variables, the pieces lose there autonomy. A change to piece "A" might break the code in piece "B", and the only way to spot the error is to look at the code in its entirety which defeats the purpose of using functions in the first place. If a function needs a value, pass in the value as a function argument. If the function generates information, pass the information back as a return.
Look at any repeated code. Why do you have a function to get the sending address and another function to get the receiving address? They both do the same thing. Modify the code so it can do both roles. You also have some duplication in the PDF writer that I don't understand at all. Why is it there?
Once your code is cleaned up a bit I think you will find your error is in how you build the label_list. When you input the items you treat label_list as a flat list that looks like this:
But when you print the labels you treat the label list like it only contains one item.
pdf.cell(100, 10, txt = str(label_list[0]) + " " + str(label_list[1]), ln = 8, align = '')The code would be simpler if the label list was a list of labels/items. label_list[0] should have all the information you need to print labels for that item (size, color, label count, item count) and label_list[1] should be the information for the next item. I would also dump the total_labels list. If you can calculate the number of labels from the item information, do the calculation when needed instead of creating another list that has to be synchronized with another list.
Hello,
The global variables could be downsized, I completely agree and I normally avoid using them. When the concept is working then I will tidy it up etc... I appreciate that currently it is a mess.
The duplication in the pdf code was only recently done. I'm new to python and to FPDF and I was originally trying to make the labels format as shown in my original post. upon failing this I left it as just the basic label format so I could change it later.
Thank you for your input though, I'll give it a clean up and see what works.
Cheers,
Jamie
while dad_has_cigs == True:
happiness = True
if dad_has_cigs == False:
print("Dad come home!")
happiness = not happiness
break