Python Forum
Does this code need to be so long?
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Does this code need to be so long?
#3
An easy way to reduce code is to write a few functions. You repeat this sequence three times followed by sleep(0.2), sleep(0.2) and no sleep.
def light_show():
    ledgreen.on()
    time.sleep(.1)
    ledred.on()
    time.sleep(.1)
    ledamber.on()
    time.sleep(.2)
    ledgreen.off()
    time.sleep(.1)
    ledred.off()
    time.sleep(.1)
    ledamber.off()

for period in (0.2, 0.2, 0):
    light_show()
    sleep(period)
Of a loop. Or a combination of function and loop like this:
def countdown():
    for _ in range(4):
        ledamber.on()
        buzzer(BuzzerObj,523,0.8,0.0)
        ledamber.off()
        time.sleep(.2)
    
    ledamber.on()
    buzzer(BuzzerObj,523,0.8,0.0)
    time.sleep(.2)
    # Leave amber on

    ledgreen.off()
    ledred.on()
    # Stop power to the relay here
    buzzer(BuzzerObj,987,3.5,0.1)
    #time.sleep(10)
    ledamber.off()
    time.sleep(5)
    ledred.off()
Reply


Messages In This Thread
RE: Does this code need to be so long? - by deanhystad - Sep-26-2022, 10:08 PM

Possibly Related Threads…
Thread Author Replies Views Last Post
  how long can a line of code be? Skaperen 2 2,290 Jun-09-2021, 06:31 PM
Last Post: Skaperen
  Factorial Code is not working when the given number is very long integer Raj_Kumar 2 2,395 Mar-31-2020, 06:40 PM
Last Post: deanhystad
  Is my Tree code too long? BladedSupernova 5 2,765 Feb-12-2020, 03:07 AM
Last Post: Larz60+

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020