Python Forum
Python code review | Tkinter gui application
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Python code review | Tkinter gui application
#13
(Nov-29-2023, 03:12 AM)rob101 Wrote:
(Nov-28-2023, 11:41 PM)Sr999 Wrote: Again appreciate your time and I am
Waiting for your review
Thanks again

You are very welcome and while I don't want to come across as an "ass" here, it was very easy to circumvent your 'admin password', so without knowing what that password is, I can see that the fake google login password is 123123.

I'm not saying that what you've created here is not good in its own right, it's just I don't think it should be used (as it is) for any serious password management, but by putting this up on GitHub, you are kind of suggesting that it could be used in such a way: sorry to be so negative about it.

Possibly (but I don't know, because I've never tried to do this) the way this could work, is to have the .csv file stored in an encrypted .zip archive (or the like of). I do know that one can create such an archive at will, but I've no clear idea how you could have your app access and use that, but it's an idea.

Hey again sorry it took me awhile to visit the post i had alot of work and little time to program, i understand your point of view and i am sorry if it came out like im trying to suggest a correct way to build password manager but i use github as a tool to easliy upload and change file contents while share to other people who can review my code and give me notes if anyone will enter my profile and will use my code without check it first it is not my resposiblity and i never mentioned inside the git repo that my code is ready to use for serivce use, it is only a learning phase program just part of my python learning..

about the security problem i did say it was weak security solution taht i found but u made me dig up lil further and i have updated the code with this additions:
-after program loads it ill ask for admin password instantly before you can access the software itself.
-each time there password request prompt the field is replaced with bullets signs ( • )
-no longer working with saved csv file but changed it to data_file.enc and store the whole csv file as encrypted file.
-after admin password inserted the software will attempt to decrypt the file if decryption was successful the content of the file will be changed to csvString and then into pandas dataFrame
-admin verification does not use a stored passoword in file or stored password in the code but just try to decrypt the data_file each time with the current inserted admin pass
-instead of save the file each time we make a change i just override the Tk.destroy function to save the current data in the panda Dataframe into encrypted file using the password inserted at the start unless the user changed the password from the "change password" button in main menu
-added search button to search for specific details about specific website
-added edit ability if you double click any cell in the table an Entry box will popup instead of the field you are trying to edit and u can re:edit the cell as you like

*****
about the Cipher.py file - this is written file i took from the lib simpleCrypt lib after failed to install the lib itself just installed the main lib Crypto
and copy paste the simpleCrypt encrypt-decrypt function into a file i created named Cipher.py
coulndt solve why i getting errors when i try to install simpleCrypt lib
*****
eventually i needed to override Tk function so i think for the next project ill start using OOP as the roots for my program instead the mess i made here xD


please review the code it self and lemme know if the solution was fine and if not give your notes im here to learn :)
Reply


Messages In This Thread
RE: Python code review | Tkinter gui application - by Sr999 - Dec-01-2023, 12:45 PM

Possibly Related Threads…
Thread Author Replies Views Last Post
  GUI application - code review Sr999 3 1,063 Jan-06-2024, 10:14 PM
Last Post: Sr999
  Code review of my rock paper scissors game Milan 0 2,214 May-25-2022, 06:59 AM
Last Post: Milan
  Review on (new) Python module: Function but Lazy Python jeertmans 3 2,636 Nov-01-2021, 06:57 PM
Last Post: ndc85430
  First time python user - Calculator code review Steamy 1 2,418 Jul-22-2020, 05:59 PM
Last Post: Larz60+

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020