Python Forum
working code, suggestion required for improvement
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
working code, suggestion required for improvement
#1
#!/usr/bin/python
from easysnmp import Session
community = 'public'
with open('zyxeldslam.txt') as ipfile:
   for sr_no, line in enumerate(ipfile, start=1):
       ip = line.strip()
       try:
# Create an SNMP session to be used for all our requests
           session = Session(hostname=ip, community=community, version=2)
# You may retrieve an individual OID using an SNMP GET
           fan1 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.1.1.2.0.1')
           fan2 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.1.1.2.0.2')
           fan3 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.1.1.2.0.3')
           temp1 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.3.1.2.0.0.1')
           temp2 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.3.1.2.0.0.2')
           temp3 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.3.1.2.0.0.3')
           fan1_status= fan1.value.encode('ascii')
           if fan1_status < str(2000):
                   fan1_status = 'Fail'
           else:
                   fan1_status = 'Ok'
           fan2_status = fan2.value.encode('ascii')
           if fan2_status < str(2000):
                   fan2_status = 'Fail'
           else:
                   fan2_status = 'Ok'
           fan3_status = fan3.value.encode('ascii')
           if fan3_status < str(2000):
                   fan3_status = 'Fail'
           else:
                   fan3_status = 'Ok'
           temp1_status = temp1.value.encode('ascii')
           temp2_status = temp2.value.encode('ascii')
           temp3_status = temp3.value.encode('ascii')
           print('{} {} {} {} {} {} {} {}'.format(sr_no, ip, fan1_status, fan2_status, fan3_status, temp1_status, temp2_status, temp3_status))
       except Exception as excp:
           print('Something went wrong!')
           print(excp)
above code is working, is there any scope for improvement.
Reply


Messages In This Thread
working code, suggestion required for improvement - by anna - Dec-28-2017, 11:39 AM

Possibly Related Threads…
Thread Author Replies Views Last Post
  Suggestion on how to speed up this code? sawtooth500 1 281 May-04-2024, 07:13 PM
Last Post: sawtooth500
  New to Python - Not sure why this code isn't working - Any help appreciated TheGreatNinx 4 1,036 Jul-22-2023, 10:21 PM
Last Post: Pedroski55
  code not working when executed from flask app ThomasDC 1 970 Jul-18-2023, 07:16 AM
Last Post: ThomasDC
  I am new to python and Could someone please explain how this below code is working? kartheekdas 2 1,071 Dec-19-2022, 05:24 PM
Last Post: kartheekdas
Exclamation My code is not working as I expected and I don't know why! Marinho 4 1,137 Oct-13-2022, 08:09 PM
Last Post: deanhystad
  My Code isn't working... End3r 4 2,006 Mar-21-2022, 10:12 AM
Last Post: End3r
  Can you give me some suggestion about PCEP Newbie1114 0 1,055 Oct-14-2021, 03:02 PM
Last Post: Newbie1114
  instagram followers name without suggestion for you jacklee26 1 3,228 Oct-02-2021, 04:57 AM
Last Post: ndc85430
  Random coordinate generator speed improvement saidc 0 2,091 Aug-01-2021, 11:09 PM
Last Post: saidc
  I don't undestand why my code isn't working. RuyCab 2 2,029 Jun-17-2021, 03:06 PM
Last Post: RuyCab

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020