#!/usr/bin/python from easysnmp import Session community = 'public' with open('zyxeldslam.txt') as ipfile: for sr_no, line in enumerate(ipfile, start=1): ip = line.strip() try: # Create an SNMP session to be used for all our requests session = Session(hostname=ip, community=community, version=2) # You may retrieve an individual OID using an SNMP GET fan1 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.1.1.2.0.1') fan2 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.1.1.2.0.2') fan3 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.1.1.2.0.3') temp1 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.3.1.2.0.0.1') temp2 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.3.1.2.0.0.2') temp3 = session.get('1.3.6.1.4.1.890.1.5.13.1.2.3.1.2.0.0.3') fan1_status= fan1.value.encode('ascii') if fan1_status < str(2000): fan1_status = 'Fail' else: fan1_status = 'Ok' fan2_status = fan2.value.encode('ascii') if fan2_status < str(2000): fan2_status = 'Fail' else: fan2_status = 'Ok' fan3_status = fan3.value.encode('ascii') if fan3_status < str(2000): fan3_status = 'Fail' else: fan3_status = 'Ok' temp1_status = temp1.value.encode('ascii') temp2_status = temp2.value.encode('ascii') temp3_status = temp3.value.encode('ascii') print('{} {} {} {} {} {} {} {}'.format(sr_no, ip, fan1_status, fan2_status, fan3_status, temp1_status, temp2_status, temp3_status)) except Exception as excp: print('Something went wrong!') print(excp)above code is working, is there any scope for improvement.
working code, suggestion required for improvement
Users browsing this thread: 1 Guest(s)