Python Forum
How can I make this function faster?
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
How can I make this function faster?
#2
with open(yaml_source) as yaml_file:
   reader = yaml.safe_load(yaml_file)
for key in value,split('.'):
    try:
        reader = reader[key]
    except (KeyError, TypeError):
        break
    return reader
i, x are terrible variable names - and your code is messy and inconsistent.
  • enumerate is redundant
  • You will never get IndexError with get
  • Use with operator to open file
  • PS When you get to a level that the value is not a dict - you may break out of the loop
Test everything in a Python shell (iPython, Azure Notebook, etc.)
  • Someone gave you an advice you liked? Test it - maybe the advice was actually bad.
  • Someone gave you an advice you think is bad? Test it before arguing - maybe it was good.
  • You posted a claim that something you did not test works? Be prepared to eat your hat.
Reply


Messages In This Thread
How can I make this function faster? - by Brennan - Jun-29-2018, 08:13 AM
RE: How can I make this function faster? - by volcano63 - Jun-29-2018, 01:41 PM

Possibly Related Threads…
Thread Author Replies Views Last Post
  How to make global list inside function CHANKC 6 3,338 Nov-26-2020, 08:05 AM
Last Post: CHANKC
  How to make this function general to create binary numbers? (many nested for loops) dospina 4 4,678 Jun-24-2020, 04:05 AM
Last Post: deanhystad
  how to make my function be a generator Skaperen 2 2,127 Jan-27-2020, 01:07 AM
Last Post: Skaperen
  How to make a function for auto generated id sunnyarora 2 3,041 May-03-2019, 12:47 PM
Last Post: Yoriz
  How can I make a faster search algorithm pianistseb 19 6,981 Apr-18-2019, 05:48 PM
Last Post: Larz60+
  To make an algorithm work faster pianistseb 3 2,942 Apr-01-2019, 08:42 AM
Last Post: Gribouillis
  Rewrite a function to make it work with 'bottle-pymysql' nikos 1 2,085 Feb-26-2019, 02:59 PM
Last Post: nikos
  Make a Function from Name String jge047 4 3,474 Dec-18-2017, 05:05 AM
Last Post: Terafy
  make a list of string in capital by using a function anancba 3 3,577 Nov-23-2017, 06:42 AM
Last Post: heiner55
  How do I make this code run faster? DontHurtMe 0 2,508 Nov-04-2017, 12:12 PM
Last Post: DontHurtMe

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020