coding improvement tips

[stullis]

Not a waste of time at all. This forum's here for people looking to learn and improve.

The first things that jumped out at me were the class name and __init__(). They are too specific. The __init__() is meant to create an instance of a class rather than running the internal code of that class. To make it more general, I would make these changes:

class Restaurant:

    def __init__(self, name, tables, **menu):
        self.name = name
        self.max_tables = tables
        self.menu = menu
        tables_occupied = 0

taj_menu = {
    'burger': {'hamburger': 5, 'chicken': 7},
    'pizza': {'cheese': 6, 'veg': 8}
}
taj = Restaurant("TajRestaurant", 10, **taj_menu)

Now, this could be TajRestaurant or Ricardo's Ristorante or Jim's Pizza Emporium with different numbers of tables, different menus, etc.

Of course, it no longer has a means to admit a new customer to the restaurant. Let's fix that and add a means to remove a customer:

def admit_new_customer(self):
    if self.tables_occupied < self.max_tables:
        self.tables_occupied += 1
    else:
        print(" Sorry we are full. Kindly wait")

def remove_customer(self):
    self.tables_occupied -= 1
    print("Thank you! Come again!")

Let's look at how our customers are ordering their food. To me, get_status() doesn't add much; if we're calling take_order(), we can suppose that the customer will answer "yes" to get_status(). Without this though, we'll need to give the customer an option to stop ordering.

Then, it calls check_item_availability() which is good. The result does not need to be stored though, we can just call the method in the if statement and be done with it.

def take_order(self):
    total_order = []
    while True:
        self.print_menu()
        user_order = input("What would you like to have?").lower()

        if user_order in ("no", "nothing", "done", "exit", "finished", "full"):
            break
        
        if self.check_item_availability(user_order):  # collect all the food items to bill
            total_order.append(user_order)
        else: print("Sorry, we don't sell that...")

    return total_order

For check_item_availability(), we can simplify the method:

def check_item_availability(self, food_item):
    return food_item in self.menu.keys()

Of course, that supposes that we aren't allowing options on the menu items. The customer could order a burger but could not select between beef and chicken. Either the menu formatting would have to change to accommodate. Personally, I would change the menu to:

taj_menu = {
    'hamburger': 5,
    'chicken sandwich': 7,
    'cheese pizza': 6, 
    'veg pizza': 8
}

We can simplify get_price() as well. Instead of iterating over the menu (which could be lengthy), it should iterate over the order since that should be shorter. We can get the prices with a dict.get() call.

def get_price(self, ordered_food):
    total = 0
    for item in ordered_food:
        total += self.menu.get(item)

    return total

The cashier() method can be simplified a little:

def cashier(self, user_food):
    print("Your bill is: $" + str(self.get_price(user_food)))

Finally, we need to run the code so, let's add a run() method. My implementation is very basic, but you get the idea:

def run(self):
    while True:
        self.admit_new_customer()
        order = self.take_order()
        self.cashier(order)
        # or self.cashier(self.take_order())
        self.remove_customer()   

The final result of this refactoring is this:

""" This module is a restaurant program.
    Ask user input to place an order. Provide multiple options to user
    to choose. """
 
class Restaurant:

    def __init__(self, name, tables, **menu):
        self.name = name
        self.max_tables = tables
        self.menu = menu
        tables_occupied = 0

    def admit_new_customer(self):
        if self.tables_occupied < self.max_tables:
            self.tables_occupied += 1
        else:
            print(" Sorry we are full. Kindly wait")

    def remove_customer(self):
        self.tables_occupied -= 1
        print("Thank you! Come again!")

    def take_order(self):
        total_order = []
        while True:
            self.print_menu()
            user_order = input("What would you like to have?").lower()

            if user_order in ("no", "nothing", "done", "exit", "finished", "full"):
                break
            
            if self.check_item_availability(user_order):  # collect all the food items to bill
                total_order.append(user_order)
            else: print("Sorry, we don't sell that...")

        return total_order
 
    def print_menu(self):
        for food in TajRestaurant.menu:
            print(food, " ", '\n  =====================', "Price: $" + self.menu.get(food))
  
    def check_item_availability(self, food_item):
        return food_item in self.menu.keys()

    def get_price(self, ordered_food):
        total = 0
        for item in ordered_food:
            total += self.menu.get(item)

        return total
 
    def cashier(self, user_food):
        print("Your bill is: $" + str(self.get_price(user_food)))

    def run(self):
        while True:
            self.admit_new_customer()
            order = self.take_order()
            self.cashier(order)
            # or self.cashier(self.take_order())
            self.remove_customer()