Python Forum
Thread Rating:
  • 1 Vote(s) - 2 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Code Review?
#2
A few random things addressed:

Github is a good idea, especially for so much code, and it's probably a good idea to post it on the site in code tags as well (for the lazy among us).
A clear entry point, using __main__ or not, helps readability.
If you're using the global keyword, you'll 99.9% be told you shouldn't (and hopefully what to do instead).
Long if/elif/else stuff can sometimes be simplified to a dictionary. You'll surely get more comments once you post the code. Python does not have switch/case/match as some other languages do.
Reply


Messages In This Thread
Code Review? - by PappaBear - Apr-18-2017, 06:06 AM
RE: Code Review? - by micseydel - Apr-18-2017, 06:24 AM
RE: Code Review? - by PappaBear - Apr-18-2017, 02:03 PM
RE: Code Review? - by micseydel - Apr-18-2017, 08:14 PM
RE: Code Review? - by PappaBear - Apr-18-2017, 10:25 PM
RE: Code Review? - by metulburr - Apr-18-2017, 10:43 PM

Possibly Related Threads…
Thread Author Replies Views Last Post
  Python best library for Excel reports & review of existing code MasterOfDestr 4 849 Feb-14-2024, 03:39 PM
Last Post: MasterOfDestr
  Review my code: convert a HTTP date header to a datetime object stevendaprano 1 2,079 Dec-17-2022, 12:24 AM
Last Post: snippsat
  Code review for S3 object creation beherap 0 2,169 Mar-29-2018, 01:31 PM
Last Post: beherap

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020