Python Forum
Thread Rating:
  • 1 Vote(s) - 2 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Code Review?
#9
Great feedback and mucho appreciatedo! 

double quotes -- The Fortinet FW requires a double quote around (some) objects.  But I was not aware Python sees " & ' equal, so good to know.

# of prints -- easy enough to change, I think I couldn't get the print to do so in a column, and took the lazy/easy path and wrote the lines individual

comments -- yes, will clean up.  I've also been seeing some code puts the comment after the line rather than above.  I find when it's after the line, I have to scroll to (to the right) too much

formating -- No idea what you're saying here...see the link, will RTFM

parenthesis  -- a product of me having multiple ifs, multiple items...will clean up

 if currentl_line[:2] 
-- I do not understand the syntax -- what the colon 2 is doing here.   Is that the following _2 items_ need to be in before the 3rd item(position 2) ? or is it those items need to be before _position 2_ ?  what is :2 representing?  


Really do appreciate the feedback... the more the better.
Reply


Messages In This Thread
Code Review? - by PappaBear - Apr-18-2017, 06:06 AM
RE: Code Review? - by micseydel - Apr-18-2017, 06:24 AM
RE: Code Review? - by PappaBear - Apr-18-2017, 02:03 PM
RE: Code Review? - by micseydel - Apr-18-2017, 08:14 PM
RE: Code Review? - by PappaBear - Apr-18-2017, 10:25 PM
RE: Code Review? - by metulburr - Apr-18-2017, 10:43 PM

Possibly Related Threads…
Thread Author Replies Views Last Post
  Python best library for Excel reports & review of existing code MasterOfDestr 4 849 Feb-14-2024, 03:39 PM
Last Post: MasterOfDestr
  Review my code: convert a HTTP date header to a datetime object stevendaprano 1 2,079 Dec-17-2022, 12:24 AM
Last Post: snippsat
  Code review for S3 object creation beherap 0 2,169 Mar-29-2018, 01:31 PM
Last Post: beherap

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020