Python Forum
class needs to refer a different class
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
class needs to refer a different class
#15
I think there is way too much code in _zio.__init__() and most of this code is not directly related to the instance being created. Only three attributes are set in this method, namely self.realname, self.tmpname, self.allfiles. I think most of this method's code should be written in an external "factory" function named for example _new_io() and the structure could be
def _new_io(name=None,mode='r',compresslevel=None,*,
            buffering=-1,
            compress=None,
            closefd=True,
            check=-1,
            encoding=None,
            errors=None,
            format=None,
            newline=None,
            tempname=False,
    ):
    ...
    zio = _zio(realname, tmpname, allfiles)
    ...
    return zio

class _zio(io.IOBase):
    def __init__(self, realname, tmpname, allfiles):
        self.realname = realname
        self.tmpname = tmpname
        self.allfiles = allfiles
    ...
zopen() and ztopen() would invoke _new_io() instead of _zio() and the advantage is that the body of _new_io() can now incorporate special cases where it returns something different from a _zio() instance, perhaps another instance of io.IOBase().
Reply


Messages In This Thread
RE: class needs to refer a different class - by Gribouillis - Jul-20-2021, 08:45 PM

Possibly Related Threads…
Thread Author Replies Views Last Post
  is ValueError a class? Skaperen 11 2,635 Mar-29-2023, 02:25 AM
Last Post: Skaperen
  extracting a function/class/method from code Skaperen 5 2,301 Mar-30-2022, 12:13 AM
Last Post: Skaperen
  first class objects Skaperen 0 962 Jan-22-2022, 02:53 AM
Last Post: Skaperen
  returning a different class Skaperen 4 2,144 Oct-20-2021, 12:51 AM
Last Post: Skaperen
  getting my head arounnd __enter__() for my new class Skaperen 5 2,554 Nov-30-2020, 09:46 AM
Last Post: Gribouillis
  find the class for indexed counting Skaperen 4 2,033 Sep-29-2020, 03:26 AM
Last Post: Skaperen
  namespaces when defining a class Skaperen 3 2,146 Jul-03-2020, 06:34 PM
Last Post: Gribouillis
  a file-like class implementation Skaperen 2 2,086 Apr-22-2020, 02:59 AM
Last Post: Skaperen
  making a generator class? Skaperen 2 2,102 Apr-01-2020, 12:34 AM
Last Post: Skaperen
  single-instance class Skaperen 3 2,569 Mar-05-2020, 12:47 AM
Last Post: Skaperen

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020