Flipping matrices problem

[Qmohankumar0017]

My question is:
A two dimensional matrix can be represented in Python row-wise, as a list of lists: each inner list represents one row of the matrix. For instance, the matrix

1 2 3
4 5 6
7 8 9
would be represented as [[1, 2, 3], [4, 5, 6], [7, 8, 9]].

A horizonatal flip reflects each row. For instance, if we flip the previous matrix horizontally, we get

3 2 1
6 5 4
9 8 7
which would be represented as [[3, 2, 1], [6, 5, 4], [9, 8, 7]].

A vertical flip reflects each column. For instance, if we flip the previous matrix that has already been flipped horizontally, we get

9 8 7
6 5 4
3 2 1
which would be represented as [[9, 8, 7], [6, 5, 4], [3, 2, 1]].

Write a Python function matrixflip(m,d) that takes as input a two dimensional matrix m and a direction d, where d is either 'h' or 'v'. If d == 'h', the function should return the matrix flipped horizontally. If d == 'v', the function should retun the matrix flipped vertically. For any other value of d, the function should return m unchanged. In all cases, the argument m should remain undisturbed by the function.

So I figured out the solution:

def matrixflip(m,d):
  newm=m[:]
  if d=='v':
    n=len(m)-1
    for i in range(0,len(m)//2):
      newm[i],newm[n-i]=newm[n-i],newm[i]
  elif d=='h':
    n=len(m[0])-1
    for i in range(0,len(m)):
      for j in range(0,len(m)//2):
        newm[i][j],newm[i][n-j]=newm[i][n-j],newm[i][j]
  return newm

The problem is that if I submit my answer, out of the two test cases when it is flipped horizontally i.e d='h' it shows side effect but it works in python interpreter in my laptop without any issues

[ichabod801]

Are the input matrices guaranteed to be square? The problem doesn't say they are. In the d == 'h' section you are using len(m) for both the iteration over rows and the iteration over columns.

You should generally iterate over the list, not the indexes of the list, as shown here. Is there some reason you are not using list.reverse() or list[::-1] to reverse the list or sub-lists?

[Qmohankumar0017]

Thank you!
Sorry didn't know that.
I'll make sure to add python tag in the future

---

Are the input matrices guaranteed to be square? The problem doesn't say they are. In the d == 'h' section you are using len(m) for both the iteration over rows and the iteration over columns.

You should generally iterate over the list, not the indexes of the list, as shown here. Is there some reason you are not using list.reverse() or list[::-1] to reverse the list or sub-lists?

I got the matrix they are using for tests.
[[1,2], [3,4]] this when flipped vertically works without any problem
But when flipped horizontally it shows side effect.(These are in the website in which I have to submit my assignment. The website provides a python 3 terminal to paste the codes and run the script)
So I tried running the same script in my laptop. Both the cases worked without any errors and I get the correct output too!

[ichabod801]

What side effect is it showing on the web site? I'm getting the correct answer on my laptop as well.

[Qmohankumar0017]

What side effect is it showing on the web site? I'm getting the correct answer on my laptop as well.

Thank you for trying it in your laptop as well, so the code works then.
The website doesn't show what side effect it is, just shows "side effect"

[ichabod801]

Got it: You're modifying m. Check m after your run and you will see that it is flipped. You are only making a shallow copy of m, you need to make a deep copy.

[Qmohankumar0017]

Got it: You're modifying m. Check m after your run and you will see that it is flipped. You are only making a shallow copy of m, you need to make a deep copy.

I didn't get it, passing the old_list to the constructor returns a new list right?
Can you please tell what should I edit?
-Thanks

[ichabod801]

You need to change line 2. n = m[:] means that n is a different list than m. However, n[0] is still the same list as m[0]. With the vertical flip, you are only modifying n, so it doesn't mess with m. But with the horizontal flip, you are changing n[0], which changes m[0], and thereby changes the overall m. You've got the right technique with the default slice [:], but you need to apply it to each sub-list of m.

[Qmohankumar0017]

You need to change line 2. n = m[:] means that n is a different list than m. However, n[0] is still the same list as m[0]. With the vertical flip, you are only modifying n, so it doesn't mess with m. But with the horizontal flip, you are changing n[0], which changes m[0], and thereby changes the overall m. You've got the right technique with the default slice [:], but you need to apply it to each sub-list of m.

Oh I totally forgot about memory management in python while solving this tricky problem.
So now I split every sublist in m and assigned that to corresponding new list and it worked.
Finally I am so relieved , was scratching my head so long for this.
Thanks a million! So glad I joined this forum.

[ichabod801]

Cool, but as I said, doing stuff index by index is not pythonic. Here's two other ways to solve the problem:

def matrixflip(m, d):
    if d == 'v':
        return m[::-1]
    elif d == 'h':
        return [row[::-1] for row in m]
    else:
        return m[:]

or:

def matrixflip(m, d):
    if d == 'v':
        return reversed(m)
    elif d == 'h':
        return [reversed(row) for row in m]
    else:
        return m[:]