Trying to convert a script from "2to3"

[JohnathanMonkey]

I cannot for the life of me get 2to3 work for me and I was wondering if anyone would be gracious enough to help me out with it. I would sincerely appreciate it.

[micseydel]

Could you elaborate? What reference resources are you using? What exactly did you try? How exactly did it not work?

[JohnathanMonkey]

Could you elaborate? What reference resources are you using? What exactly did you try? How exactly did it not work?

Hello! Thank you for responding!

I am using this video as a reference:

Hide/Show

https://www.youtube.com/watch?v=8qxKYnAsNuU

It does it's thing, but never tells me to "try" to fix anything. So, I assumed that it corrected all of the mistakes, I typed -w in my command to write it and it created the script and the backup, but when I remove Python2, it asks me what program I want to use to open it. When I choose Python (33), it opens the program, but it's not working correctly. Basically, it is supposed to "sign" tga images with specific names. But even though it is in the same folder with the tga files, it's like they don't exist if that makes any sense at all. Am I allowed to post my script here? I am a complete infant when it comes to this so please bear with me.

---

Could you elaborate? What reference resources are you using? What exactly did you try? How exactly did it not work?

Here is the Python 2 script:

Hide/Show

import struct
import msvcrt as m
import os

def wait():
    m.getch()
    
def readByte(file):
    return struct.unpack("B", file.read(1))[0]
 
def readu16le(file):
    return struct.unpack("<H", file.read(2))[0]
 
def readu32le(file):
    return struct.unpack("<I", file.read(4))[0]


tgas = ["iconTex.tga","bootLogoTex.tga","bootDrcTex.tga","bootTvTex.tga"]
dimensions = [[128,128,32],[170,42,32],[854,480,24],[1280,720,24]]
for i in range(len(tgas)):
    tga = tgas[i]
    dimension = dimensions[i]
    if os.path.exists(tga):
        with open(tga,"rb+") as f:
            header = readu32le(f)
            if header != 0x00020000:
                print tga + "is compressed. it cant be compressed!"
                break
            f.seek(12)
            actDimensions = [readu16le(f),readu16le(f),readByte(f)]
            hasHadBadDiment = False
            for j in range(len(actDimensions)):
                if j == 0:
                    type = "width"
                elif j == 1:
                    type = "height"
                else:
                    type = "depth"
                diment = dimension[j]
                actDiment = actDimensions[j]
                if diment != actDiment:
                    if not hasHadBadDiment:
                        hasHadBadDiment = True
                        print "dimensions are not valid for: " + tga
                    print type + " is: " + str(actDiment) + " should be: " + str(diment)
            if hasHadBadDiment:
                break
            f.seek(1,1)
            f.seek(actDimensions[0]*actDimensions[1]*(actDimensions[2]/8),1)
            f.write("\x00\x00\x00\x00\x00\x00\x00\x00TRUEVISION-XFILE\x2E\x00")
    else:
        print tga + " could not be found!"
print "All TGA's verified!"
print "press any key to exit..."
#todo verifiy bootovie.h264
wait()        

And here is the 2to3 converted Python 3 script:

Hide/Show

import struct
import msvcrt as m
import os

def wait():
    m.getch()
    
def readByte(file):
    return struct.unpack("B", file.read(1))[0]
 
def readu16le(file):
    return struct.unpack("<H", file.read(2))[0]
 
def readu32le(file):
    return struct.unpack("<I", file.read(4))[0]


tgas = ["iconTex.tga","bootLogoTex.tga","bootDrcTex.tga","bootTvTex.tga"]
dimensions = [[128,128,32],[170,42,32],[854,480,24],[1280,720,24]]
for i in range(len(tgas)):
    tga = tgas[i]
    dimension = dimensions[i]
    if os.path.exists(tga):
        with open(tga,"rb+") as f:
            header = readu32le(f)
            if header != 0x00020000:
                print(tga + "is compressed. it cant be compressed!")
                break
            f.seek(12)
            actDimensions = [readu16le(f),readu16le(f),readByte(f)]
            hasHadBadDiment = False
            for j in range(len(actDimensions)):
                if j == 0:
                    type = "width"
                elif j == 1:
                    type = "height"
                else:
                    type = "depth"
                diment = dimension[j]
                actDiment = actDimensions[j]
                if diment != actDiment:
                    if not hasHadBadDiment:
                        hasHadBadDiment = True
                        print("dimensions are not valid for: " + tga)
                    print(type + " is: " + str(actDiment) + " should be: " + str(diment))
            if hasHadBadDiment:
                break
            f.seek(1,1)
            f.seek(actDimensions[0]*actDimensions[1]*(actDimensions[2]/8),1)
            f.write("\x00\x00\x00\x00\x00\x00\x00\x00TRUEVISION-XFILE\x2E\x00")
    else:
        print(tga + " could not be found!")
print("All TGA's verified!")
print("press any key to exit...")
#todo verifiy bootovie.h264
wait()        

[Skaperen]

and what comes out as py3 code that does not work? (/me not looking at the code, yet)

[JohnathanMonkey]

and what comes out as py3 code that does not work?  (/me not looking at the code, yet)

It states that the files are not found, even though they are in the same folder as the script, which is how it is supposed to be.

[Skaperen]

in line 8 of either source code where does the variable name file come from?

is this "files not found" issue happening when you run your script or when you run 2to3 ?

[buran]

Files (I assume that's the tga files) not found sounds like problem with the way you run the script (i.e. paths where it is looking for the files), not a problem with 2to3 conversion.

---

by the way file is built-in function in python2 so I would not use it as argument to the functions. Same for type.

[Skaperen]

file is gone in python 3.   so i wonder how 2to3 will handle that

[buran]

file is gone in python 3.   so i wonder how 2to3 will handle that

You can look at the result code posted by the OP. Anyway I don't think this could cause problem as long as he doesn't try to use it as originally intended.
Note that it doesn't rise an exception, just os.path.exists cannot find the files.

[JohnathanMonkey]

Thank you guys for your help! The picture below is how it should look, but instead, it says that the files can't be found, but that they were verified.

[Image: fwhfgi.png]