Unpacking dictionary from .xlsx as Kwargs

[etjkai]

Summary: I'm looking to make my code more Pythonic. It works, but I'm just uneasy knowing that there's probably a better solution elsewhere

I've tried creating a web automation script with Selenium, that allows users to choose which fields to change. The Excel file which the script reads from, is as follows



Meaning first row, col_72708 will have 4 fields edited. Second row will have 2 fields edited, and the last row will have only 1 field edited.

I then read this file as multiple dictionaries. Key being the column header, and Value being the actual value (in the table).

I then unpack this dictionary into my function (with **), which has kwargs of default value 0. My function has multiple if statements, so if the kwarg passed in is blank, it skips the function that makes the amendment in the script.

This code is functionally sufficient, but I'm confident that there must be a better way to do this.

I hope I'm sufficiently clear to facilitate anyone giving me advice on this.

Many thanks!

[etjkai]

bump (am I allowed to do this?)

[buran]

bumping from time to time when reasonable amount of time has passed is OK
It's difficult to tell what can be improved without seeing any code

[ThomasL]

As Raymond Hettinger uses to say: "There´s always a better way".
I recommend watching his tutorials on Youtube.

[micseydel]

I agree that bumping is fine, but I want to point out that the same people that see your bump are the ones that overlooked your question already. Instead of just bumping, you should try to improve your question. As mentioned, providing your Python code is essential to finding what's not Pythonic about it - we could go back and forth in natural language about it, but to truly get us all on the same page, you should provide the code.

[etjkai]

Thank you for the clarification.

For the first part of my question, I'm having the below function. The kwargs have default value of 0, and the if clause is skipped if the user does not assign a value to the kwarg. Is this conceptually the way to do so?

def master_update(subproj_n, p_BaseSynergy=0, p_synergyproject=0, p_impact_date=0, p_new_name=0, p_totalValue=0):
    
    opening_subproject(subproj_n)
    
    if p_BaseSynergy:
        f_BaseSynergy(subproj_n, p_BaseSynergy)
    if p_synergyproject:
        f_synergyproject(subproj_n, p_synergyproject)
    if p_impact_date:
        f_impact_date(subproj_n, p_impact_date)
    if p_new_name:
        f_update_name(subproj_n, p_new_name)
    if p_totalValue:
        f_update_values(subproj_n, p_totalValue)
    
    closing_subproject()