Having issues with open,write,read

[dudeisbrendan03]

import sys
import os
import time

from pathlib import Path


my_file = Path("database.txt")

print("I HIGHLY RECOMMEND USING DATABASE.TXT AS I HAVE NOT REWROTE THE SCRIPT TO ALWAYS USE THIS VALUE")
f = "database.txt"
try:
    file = open(f, 'r')
except IOError:
    file = open(f, 'w')

if my_file.is_file():
    
#    f= open("database.txt","w+")
    f= open("database.txt","r+")
    
    infilename = "database.txt"
    with open(infilename, "r") as f:
        line_list = f.readlines()
    
#    f = f.readlines()
    f.close()
    found = False
    f= open("database.txt","r+")
    for line in f:
        if str("users") in line:
            print ("Found it")
            print ("Beginning database edit/user add")
            print ("You will be requested for input soon")
            usernamenew = input("New DB username: ")
            passwordnew = input("New DB password: ")
            f= open("database.txt","a+")
            f.write("UN: {}".format(usernamenew))
            f.write("UP: {}".format(passwordnew))
            found = True

    if not found:
        print("Not found")
#     else:
        f = open('database.txt', 'a')
        f.write(str("NUN: root 1")+"\n")
        f.close()
        print("\nCreating database")
        time.sleep(3)
        print(".")
        time.sleep(1)
        print("..")
        time.sleep(1)
        print("...")
        time.sleep(1)
        print(".")
        time.sleep(1)
        time.sleep(5)
        print("\nCreating user")
        print(".")
        time.sleep(1)
        print("..")
        time.sleep(1)
        print("...")
        time.sleep(1)
        print(".")
        time.sleep(6)
        confirm = input("\nAre you sure you wish to write changes? Y/N: ")
        if confirm == str("Y") or str("y"):
            print("\nWriting changes NOW")
            f= open("database.txt","w+")
            f.close
            for i in range(1):
                f= open("database.txt","a+")
                f.write("users \r\n")
                f.write("NUN: root %d\r\n" % (i+1))
                f.write("NUP: root %d\r\n" % (i+1))
                f.close
            for i in range(1):
                f= open("database.txt","w+")
                f.write("users \r\n")
                f.write("NUN: root %d\r\n" % (i+1))
                f.write("NUP: root %d\r\n" % (i+1))
                f.close        
        else:
            print("You have aborted the database creation")
            print("The following script may not run. This is due to no/invalid database installation")

The above script works perfectly, but this: 

try:
    file = open(f, 'r')
except IOError:
    file = open(f, 'w')

if my_file.is_file():
    
#    f= open("database.txt","w+")
    f= open("database.txt","r+")
    
    infilename = "database.txt"
    with open(infilename, "r") as f:
        line_list = f.readlines()
    
#    f = f.readlines()
    f.close()
    found = False
    f= open("database.txt","r+")
    for line in f:
        if str("users") in line:
            print ("Found it")
            print ("Beginning database edit/user add")
            print ("You will be requested for input soon")
            usernamenew = input("New DB username: ")
            passwordnew = input("New DB password: ")
            f= open("database.txt","a+")
            f.write("UN: {}".format(usernamenew))
            f.write("UP: {}".format(passwordnew))
            found = True

Does not. It takes the values, but then does not write them to the file, the rest of the script works fine.
Any ideas?

(The time stuff is just because I wanted some sort of loading thing. Didnt have to work. Got bored. And I get NO ERROR when running the script.)

[wavic]

You must specify a file name as a parameter to open - open(f, 'r'). What does "f" contain?

In line 6 - if my_file.is_file():. To check if something is a file

if os.path.isfile(file_name):
    # do

Also, you are opening one file twice with different flags. Line 9, line 12.

[dudeisbrendan03]

You must specify a file name as a parameter to open - open(f, 'r'). What does "f" contain?

In line 6 - if my_file.is_file():. To check if something is a file

if os.path.isfile(file_name):
    # do

Also, you are opening one file twice with different flags. Line 9, line 12.

Thanks for the reply, but I got nothing, didn't work. The file did not update.

EDIT: In fact when I removed line 9 it didnt detect the file and on line 12 I get an IO error, because python automatically closes the file.

[wavic]

How did you modify the code? Is there an error message? What you expect to happen but it does not? You can't just say "it doesn't work". I have to look at my crystal bow. If I remember where I left it

[dudeisbrendan03]

How did you modify the code?

When I removed line 9 it didnt detect the file and on line 12 I get an IO error, because python automatically closes the file.

[wavic]

Yes, because in line 16 you are closing a file which is not open.

[dudeisbrendan03]

Yes, because in line 16 you are closing a file which is not open.

I commented it out before I ran it before. Forgot to say that. Sorry.

EDIT: Realised I commented the wrong line. Commented the right line out, ran again. No IO error, but nothing is written to the file.

[wavic]

Did you write this code?

Again, in line 18 you are opening the file to read it. Without closing it, in line 26 you are opening it again to appending to it. You have to close this one too.

[dudeisbrendan03]

Did you write this code?

Again, in line 18 you are opening the file to read it. Without closing it, in line 26 you are opening it again to appending to it. You have to close this one too.

Yes, I wrote this code. Python is not my expertise. Im more of a HTML kinda guy, a teacher decided to get me into python. So here I am making a useless script to modify a text file, for another python script that reads that text file.
Because
I have nothing to do in my spare time. So im not the 'greatest' and I make very buggy software.
Also, I do not need to close from line 26 as python closes it as it is the end of a block.
If I put f.close at the start of the 

if str("users") in line:

block then python will start going mental saying that it cant run anything due to the block being based of a value that depends on the file being open.
I did try commenting out line 26 and running it. Still nothing written.
I may give up and redo the whole thing. In theory it SHOULD work, but doesnt.

[zivoni]

You should remove code that does nothing to increase clarity.

I guess that code that do something starts on line 18. You are opening same file twice (not a problem), under same handle (again not a problem, but very confusing) and you are opening both of them in write mode (or append). That could be problem - they are closed automatically, but their content might depend on order of closing. You should open it on line 18 just for reading - you dont need more. And explicitly close your "second" file after line 28. Even better would be to use with for that file.