Convert .MTS files

[snippsat]

I've amended my code per your instructions. It is now

Not really
Copy all of my code,see that i have made changes here

f'{path_out+os.path.splitext(file.name)[0]}.mp4'])

And path_out need to end with a backslash(/).

path_out = 'C:/upload/completed/'

[pberrett]

I've now added the slashes

import subprocess
import os
path_in = 'C:/upload/'
path_out = 'C:/upload/completed/'
 
for file in os.scandir(path_in):
    if file.name.endswith('mts'):
        #print(file.name)
        file_path = os.path.join(path_in, file.name)
        subprocess.run(['ffmpeg', '-i', f'{file_path}', '-c:v', 'copy', f'{path_out+os.path.splitext(file.name)[0]}.mp4'])

result remains

Output:
>>> 
= RESTART: C:/Users/Peter/AppData/Local/Programs/Python/Python36-32/test2.py =
>>> 

[snippsat]

I've now added the slashes

Only needed for last one.

path_in = 'C:/upload'
path_out = 'C:/upload/completed/'

Add .:

endswith('.mts'):

Folder complete most excites.

You know that is test this with mkv to mp4?
I don't have mts files,so not sure if that subprocess(ffmpeg) command work for mts.
You most change subprocces command to what work for mts file on command line(ffmpeg).
So based on you previous post.

subprocess.run(['ffmpeg', '-i', f'{file_path}', '-r', '30', '-c:v', 'libx264', '-crf', '23', '-ac', '1',  f'{path_out+os.path.splitext(file.name)[0]}.mp4'])

[snippsat]

Here is function to make it cleaner.

import subprocess
import os

def convert_video(path_in, path_out, to_file_ext, org_ext):
   '''
   Convert video files in a folder to different format
   Change ffpmeg command in subprocess to fit single ffmpeg command line run
   '''
   for file in os.scandir(path_in):
       if file.name.endswith(f'.{org_ext}'):
           file_path_in = os.path.join(path_in, file.name)
           path_out = f'{path_out}/'
           file_path_out = f'{path_out+os.path.splitext(file.name)[0]}.{to_file_ext}'
           subprocess.run(['ffmpeg', '-i', f'{file_path_in}', '-c:v', 'copy', f'{file_path_out}'])

if __name__ == '__main__':
   path_in = 'C:/ffmpeg_new/bin'
   path_out = 'C:/ffmpeg_new/old'
   org_ext = 'mkv'
   to_file_ext = 'mp4'
   convert_video(path_in, path_out, to_file_ext, org_ext)

So beside obvious changes like path and format.
Change ffmpeg command to what you run before from command line.
Eg:

subprocess.run(['ffmpeg', '-i', f'{file_path_in}', '-c:v', 'libx264', '-vf', 'scale=1280:720', '-crf', '23', f'{file_path_out}'])
subprocess.run(['ffmpeg', '-i', f'{file_path_in}', '-r', '30', '-s', '1280x720', '-c:v', 'libx264', '-crf', '23', '-ac', '1', f'{file_path_out}'])

[zivoni]

Just a question about using of f-strings (as I am still on 3.5.x, its use occasionally confuse me). Is there any benefit in using path_out =  f'{path_out}/' instead of path_out += "/" or using f'{file_path_in}' instead of file_path_in?

    path_out = f'{path_out}/'
    file_path_out = f'{path_out+os.path.splitext(file.name)[0]}.{to_file_ext}'

    file_path_out = os.path.join(path_out, f'{os.path.splitext(file.name)[0]}.{to_file_ext}')

[snippsat]

or using f'{file_path_in}' instead of file_path_in?

I just forget to remove f after i moved expression of the subprocess line.
So it should like this.

import subprocess
import os

def convert_video(path_in, path_out, to_file_ext, org_ext):
   '''
   Convert video files in a folder to different format
   Change ffpmeg command in subprocess to fit single ffmpeg from command line
   '''
   for file in os.scandir(path_in):
       if file.name.endswith(f'.{org_ext}'.upper()):
           file_path_in = os.path.join(path_in, file.name)
           path_out = f'{path_out}/'
           file_path_out = f'{path_out+os.path.splitext(file.name)[0]}.{to_file_ext}'
           subprocess.run(['ffmpeg', '-i', file_path_in, '-c:v', 'copy', file_path_out])
           #subprocess.run(['ffmpeg', '-i', file_path_in, '-c:v', 'libx264', '-vf', 'scale=1280:720', '-crf', '23', file_path_out])

if __name__ == '__main__':
   path_in = 'C:/ffmpeg_new/bin'
   path_out = 'C:/ffmpeg_new/old'
   org_ext = 'MTS'
   to_file_ext = 'mp4'
   convert_video(path_in, path_out, to_file_ext, org_ext)

@pberrett i have tested with MTS file downloaded from here.
Both subprocess lines in script over work,
first line just copy video format.
Second line re scale and use H.264 video(libx264') format.

[pberrett]

Hi all

I have finished my program and it works fine. Thanks to everyone who helped. Here is the finished result.

#Program for converting .mts files to .mp4 files and uploading these to a server.

import subprocess
import os, sys
import ftplib

# function for converting videos to specified format
def convert_video(path_in, path_out, to_file_ext, org_ext):
  '''
   Convert video files in a folder to different format
   Change ffpmeg command in subprocess to fit single ffmpeg from command line
   '''
  for file in os.scandir(path_in):
      if file.name.endswith(f'.{org_ext}'.upper()):
          file_path_in = os.path.join(path_in, file.name)
          path_out = f'{path_out}/'
          file_path_out = f'{path_out+os.path.splitext(file.name)[0]}.{to_file_ext}'
          subprocess.run(['ffmpeg', '-i', file_path_in, '-r', '30', '-s', '1280x720', '-c:v', 'libx264', '-crf', '22', '-ac', '1', file_path_out])

print ("Starting...")

path_in = 'C:/upload' # files for conversion and uploading are stored here
path_out = 'C:/uploadtemp' # converted files are stored here temporarily

#call videos to be processed

if __name__ == '__main__':

  org_ext = 'MTS'
  to_file_ext = 'mp4'
  convert_video(path_in, path_out, to_file_ext, org_ext)
  
print ("Conversions finished...")

# FTP sessiona and uploading 

os.chdir("/uploadtemp")
session = ftplib.FTP('myserver.com','mylogin','mypassword')
path = "/uploadtemp"
dirs = os.listdir( path )

#upload each file
for eachfile in dirs:
   file = open(eachfile,'rb')                  # file to send
   session.storbinary('STOR ' +eachfile, file)     # send the file

file.close()                                    # close file and FTP
session.quit()

print ("converted files uploaded...")

#clear temporary directory

for eachfile in dirs:
   os.remove(eachfile)

print ("Temporary directory emptied...")

#clear directory with files for conversion

path= "/upload"
dirs = os.listdir( path )
os.chdir("/upload")
for eachfile in dirs:
   os.remove(eachfile)

print ("Upload directory emptied...")

print ("Finished")

The way this works is that lets' say I have a bunch of mts files I want to convert to mp4 files and then upload the results to a certain ftp server. This script converts the files into mp4 files which are put into the c:\uploadtemp directory. they are then uploaded to the ftp server and both c:\upload and c:\uploadtemp are both emptied of all files.

Any comments are welcome.

cheers Peter