My while loop won't loop

[JHem]

Hello! I'm new to python and I'm trying to solve a homework exercise that covers while-loops but the problem is that my while loop won't loop...

The instructions for the exercise:

You should complete a program that takes care of rolling the dice so that there are new rolls as long as the last roll is larger than the previous one. Here's how the program starts (this is ready, you should not write it):
myRoll = 0 # represents the latest roll, start value 0
mySum = 0 # Sum for points collected
dice = random.randint(1,6) # Here new cast is generated between 1 and 6

Write a while-loop that runs as long as the newest roll (in the variable dice) is larger than the previous roll (its starting value can be found in myRoll)! Inside the loop:

- the latest roll should be added to mySum
- myRoll should get the value of the last roll
- a new roll must be generated for the variable dice.
- this number should be printed with print "Now you threw:", dice

When the newest roll is less than or equal to the most recent, the while loop must end and the score must be printed (it must not contain the latest roll) with two print sets. The first set should print the text "Your sum:" and the second should print the score. Do not print anything else!

Example of the functioning program:

Now you threw: 1
Now you threw: 3
Now you threw: 4
Now you threw: 4
Your sum:
8

This is what I've done so far:

while True: 
    if dice > myRoll:
        mySum += dice
        myRoll = dice
    
    elif dice <= myRoll:
        print("Your sum:")
        print(mySum)
        break

But it won't loop. It will toss the dice once and then it prints out the sum. I can't just wrap my head around it, what am I doing wrong here?

[Larz60+]

Show more code, in your submitted code:

• There's no indication of what value of dice value is prior to entering loop
  
• There's no indication of what myRoll value is prior to entering loop
  
• Above refer to initialization
  
• if dice > myRoll there will be no display, but myRoll will be set to dice value
  so on next iteration, elif will execute since there equal. This will display results,
  and exit the loop (the break statement).
  

[pyzyx3qwerty]

Just because your while loop doesn't work, it doesn't always mean the problem is in the loop itself - it may be something else outside your while loop. Show your full code, to help us help you.

[perfringo]

I suspect that your 'while' loop executes exactly as written:

- first loop: 'if' condition evaluates to True (as myRoll initially is 0 and dice is in range 1..6) and assignment is made myRoll = dice
- second loop:'if' condition is not True anymore (myRoll and dice are equal) and 'elif' clause is executed (print & break).

[JHem]

import random

myRoll = 0
mySum = 0
dice = random.randint(1,6)
print("Now you threw:", dice)

while True: 
    if dice > myRoll:
        mySum += dice
        myRoll = dice
     
    elif dice <= myRoll:
        print("Your sum:")
        print(mySum)
        break

Here's all the code. I previously left out the ones from the beginning that were already included (that I didn't have to write myself).

I suspect that your 'while' loop executes exactly as written:

- first loop: 'if' condition evaluates to True (as myRoll initially is 0 and dice is in range 1..6) and assignment is made myRoll = dice
- second loop:'if' condition is not True anymore (myRoll and dice are equal) and 'elif' clause is executed (print & break).

Thank you for the answer and for clarifying. I know while loop will continue the loop unless the condition becomes false. However I don't understand how I can assign the value from the variable "dice" to the variable "myRoll" without it breaking the condition. "myRoll should get the value of the last roll", but I don't know how to do this.

[perfringo]

Always read assignment carefully:

Inside the loop:

- the latest roll should be added to mySum
- myRoll should get the value of the last roll
- a new roll must be generated for the variable dice.
- this number should be printed with print "Now you threw:", dice

Do you have last two inside your loop?

[JHem]

Always read assignment carefully:

Inside the loop:

- the latest roll should be added to mySum
- myRoll should get the value of the last roll
- a new roll must be generated for the variable dice.
- this number should be printed with print "Now you threw:", dice

Do you have last two inside your loop?

Okay this really cleared things up for me, thank you! :) I fixed my code and got it to work like it should eventually. I guess I just assumed that those two things were already included inside the loop.