Python Forum
Random Passcode Generator function
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Random Passcode Generator function
#1
Hi, I just started learning to program a couple months ago, and I wrote this function to generate a Password to a desired length. Please tell me what you think, and if/how it can be improved upon... Thank you

def pass_code_generator(x):
    saved_variable = ""
    while len(saved_variable) <= x:
        alphabet = list("abcdefghijklmnopqrstuvwxyz")
        rndm_lttr = random.randint(0,25)
        rndm_number = random.randint(0,10)

        if rndm_number % 2 == 0:
            rndm_number = str(rndm_number)
            saved_variable += rndm_number
        else:
            saved_variable+= saved_variable.join(alphabet[rndm_lttr:rndm_lttr+1])
            
    return saved_variable
buran write Jan-06-2021, 11:00 AM:
Please, use proper tags when post code, traceback, output, etc. This time I have added tags for you.
See BBcode help for more info.
Reply
#2
I think it will put only even numbers into your generated code (and will replace odd numbers to letters), won't it? Maybe I wouldn't close out even numbers.

from random import *
def pass_code_generator(x):
    saved_variable = ""
    while len(saved_variable) <= x:
        alphabet = list("abcdefghijklmnopqrstuvwxyz")
        rndm_lttr = randrange(0,25)
        rndm_number = randrange(0,10)
        if rndm_lttr >= 12:
            rndm_number = str(rndm_number)
            saved_variable += rndm_number
        else:
            saved_variable+= saved_variable.join(alphabet[rndm_lttr:rndm_lttr+1])
             
    return saved_variable
Reply
#3
@horrorfodrasz, star import is considered bad practice and is generally discouraged

Both code snippets have caveats that - e.g. omit letters at certain indexes, while add numbers instead.
also I don't think you understand how this line works

saved_variable+= saved_variable.join(alphabet[rndm_lttr:rndm_lttr+1])

as an advise - look at random.choices()
If you can't explain it to a six year old, you don't understand it yourself, Albert Einstein
How to Ask Questions The Smart Way: link and another link
Create MCV example
Debug small programs

Reply


Possibly Related Threads…
Thread Author Replies Views Last Post
  Real Random Number Generator woodturner550 21 1,798 Feb-01-2024, 03:19 PM
Last Post: DeaD_EyE
  random two-word domain name generator rootVIII 0 2,078 Aug-06-2019, 03:15 AM
Last Post: rootVIII

Forum Jump:

User Panel Messages

Announcements
Announcement #1 8/1/2020
Announcement #2 8/2/2020
Announcement #3 8/6/2020