Replacing text in xml

[ateestructural]

I have this code but the text is not replaced in the file titled: file_name (although as a python string the replacement is correct but I expected to change in file_name)

Can anyone figure why is that?

def xml_parsing(file_name, append_values, search_1, search_2):
    
    from xml.etree import ElementTree
    with open(file_name, 'rb+') as f:
        tree = ElementTree.parse(f)
        root = tree.getroot()
        
        root.find(search_1).text.replace("(VALUE)DS-L462-060901-C01-21(/VALUE)", "(VALUE)" + str(append_values[0]) + "(/VALUE)")

    tree.write(file_name, xml_declaration=True, encoding='utf-8') 

[ateestructural]

I shall be extremely grateful if someone can help?

[bowlofred]

You are calling replace() on a string. But that just returns the modified string, it doesn't change the original object.

>>> x = "foobar"
>>> x.replace("foo", "XX")
'XXbar'
>>> x
'foobar'

In your line 8, it is returning a value of the replaced text, but you are not capturing or doing anything with the value. In the meantime, root and the object that it points to are unmodified.

Probably something like:

        element = root.find(search_1)
        element.text = element.text.replace("(VALUE)DS-L462-060901-C01-21(/VALUE)", "(VALUE)" + str(append_values[0]) + "(/VALUE)")

[ateestructural]

Thank you very much, that sorted it. Much appreciated and obliged

[motherboardinfo]

Thankyou for sharing this