Python project help

[gullidog]

My code when run is sating 'opt is not defined'

#School Register
import time
def Menu():
   print("""   Welcome to SchoolReg

                1.Create Register
                2.Access Register
                Press 'Q' to quit""")
   opt = input("              Please select an option:")

def Create(opt):
   file = open("SchoolRegister.txt","w")
   file.write(reg_create)

def Acess(opt):
   file = open("SchoolRegister.txt","r")
   print(file.read())

def Quit(opt):
   print("Thank you for using SchoolReg, goodbye!")
   time.sleep(3)
   quit()

Menu()

if opt == '1':
   reg_create = input("Please enter the people present\n")
   Create(opt)
   

[sparkz_alot]

Well, that was a bit of a mess   , lets see if we can partially fix it a bit.

# School Register
import time

# Python loves lower case function names


def create():
   # Using this method, Python will close the file automatically
   with open("SchoolRegister.txt", "w") as file:
       reg_create = input("Please enter the people present\n")
       file.write(reg_create)


def access():
   # Using this method, YOU must close the file
   file = open("SchoolRegister.txt", "r")
   print(file.read())
   file.close()


def leave():
   print("Thank you for using SchoolReg, goodbye!")
   time.sleep(3)
   quit()


def menu():
   print("""   Welcome to SchoolReg

               1.Create Register
               2.Access Register
               Press 'Q' to quit""")
   opt = input("              Please select an option: ")
   if opt == '1':
       create()
   elif opt == '2':
       access()
   elif opt == 'Q':    # Python does NOT love using it's keywords, such as 'quit'
       leave()

   return


menu()

[gullidog]

Well, that was a bit of a mess , lets see if we can partially fix it a bit.

 # School Register import time # Python loves lower case function names def create():    # Using this method, Python will close the file automatically    with open("SchoolRegister.txt", "w") as file:        reg_create = input("Please enter the people present\n")        file.write(reg_create) def access():    # Using this method, YOU must close the file    file = open("SchoolRegister.txt", "r")    print(file.read())    file.close() def leave():    print("Thank you for using SchoolReg, goodbye!")    time.sleep(3)    quit() def menu():    print("""   Welcome to SchoolReg                1.Create Register                2.Access Register                Press 'Q' to quit""")    opt = input("              Please select an option: ")    if opt == '1':        create()    elif opt == '2':        access()    elif opt == 'Q':    # Python does NOT love using it's keywords, such as 'quit'        leave()    return menu() 

What looks wrong??

[sparkz_alot]

Not a slam, just an observation.

If you compare the code you posted versus the 'cleaned' up code I posted you'll see several changes to your code. I also added a few comments to help clarify. There are still a few things that could be improved and I'm sure they will be addressed as you expand you script.

If you have questions about what I did or why, feel free to ask.

[gullidog]

Not a slam, just an observation. If you compare the code you posted versus the 'cleaned' up code I posted you'll see several changes to your code. I also added a few comments to help clarify. There are still a few things that could be improved and I'm sure they will be addressed as you expand you script. If you have questions about what I did or why, feel free to ask.

Is there anyway I could include arrays in my code do you think?

[Larz60+]

an array is called a list in python, and is defined as follows:

mylist = [] # empty list
mylist = ['dogs', 'cats', 'rabbits', 'mice']

or programmatically like:

mylist = [] # empty list
mylist.append('dogs')

to display contents:

mylist = ['dogs', 'cats', 'rabbits', 'mice']

for animal in mylist:
    print(animal)

There are many variations of this, and a good read of the docs, or a tutorial would be in order.

[gullidog]

an array is called a list in python, and is defined as follows: mylist = [] # empty list mylist = ['dogs', 'cats', 'rabbits', 'mice'] or programmatically like:

 mylist = [] # empty list mylist.append('dogs') 

to display contents:

 mylist = ['dogs', 'cats', 'rabbits', 'mice'] for animal in mylist: print(animal) 

There are many variations of this, and a good read of the docs, or a tutorial would be in order.

I know what an array is I just wondered if there was a way that I could implement it in my code.

[Larz60+]

You could use a dictionary:

import sys

def create():
    print('Create routine')

def access():
    print('access routine')

def leave():
    sys.exit(0)

def menu():
    while True:
        options = {'1': create, '2': access, 'Q': leave}
        print("""   Welcome to SchoolReg
    
                   1.Create Register
                   2.Access Register
                   Press 'Q' to quit""")
        opt = input("              Please select an option: ")
        try:
            options[opt]()
        except KeyError:
            print('Not a valid choice, Try again')

menu()