problem usage of static method

[akbarza]

hi
in the below code:

'''
static method
https://builtin.com/software-engineering-perspectives/python-cls
'''


class Math:
  @staticmethod
  def factorial(number):
        if number == 0:
            return 1
        else:
            return number * MethodTypes.factorial(number - 1)
       
factorial = MethodTypes.factorial(5)
print(factorial)

after running the below error is given:

Error:
Traceback (most recent call last):
  File "<string>", line 15, in <module>
NameError: name 'MethodTypes' is not defined

the code is in the address mentioned in the docstring.
what is the problem? also why in the implementation of the function in line 13, MethodTypes is used?
thanks

[Gribouillis]

The blog's code is broken. It should be Math instead of MethodTypes.

[paul18fr]

maybe the following snippet gives you some answers:

import math

class OwnMath:
    
    @staticmethod
    def factorial(number):
      if number == 0:
          return 1
      else:
          return number * OwnMath.factorial(number - 1)


if __name__ == '__main__':
    
    n = 9
    
    factorial1 = math.factorial(n)  # using math library
    factorial2 = OwnMath.factorial(n)  # using "OwnMath" class + recursive method
    
    print(f"factorial1 with math library = {factorial1}")
    print(f"factorial2 with proper implementation= {factorial2}")

[deanhystad]

I went to the mentioned link and this is the first thing I saw.

The difference between the keywords self and cls reside only in the method type. If the created method is an instance method then the reserved word self to be used, but if the method is a class method then the keyword cls must be used.

This does not give a good first impression. "self" and "cls" are conventions. You should use "self" as the first argument in an instance method and "cls" is the first argument in a class method, but there is nothing in Python that says you "must" use these words.

This is followed by more misinformation:

A static method in Python must be created by decorating it with @staticmethod.

This adds a static method to the class Math

def func(number):
    result = 1
    for value in range(1, number+1):
        result *= value
    return result


class Math:
    pass

Math.factorial = func

print(Math.factorial(5))

Add on to this that the provided example of a static method contains a glaring error, and the indenting isn't even consistent. What a mess.

[akbarza]

maybe the following snippet gives you some answers:

import math

class OwnMath:
    
    @staticmethod
    def factorial(number):
      if number == 0:
          return 1
      else:
          return number * OwnMath.factorial(number - 1)


if __name__ == '__main__':
    
    n = 9
    
    factorial1 = math.factorial(n)  # using math library
    factorial2 = OwnMath.factorial(n)  # using "OwnMath" class + recursive method
    
    print(f"factorial1 with math library = {factorial1}")
    print(f"factorial2 with proper implementation= {factorial2}")

hi
thanks for reply
can I ask why you have used ownMath in line 10 of your code? I ask this question because factorial function has been defined in the class. I tested the cod by removing ownMath, it caused an error.
thanks again

[paul18fr]

You're doing the same when using classically "math.factorial" => "class.method"

Here you're creating your "OwnMath" class With your own "factorial" method (récursive use) => "OwnMath.factorial"

Do an additionnal basic test changing the method name to check you're calling your own method