Palindrome in Python - result always false

[RavCOder]

I didn't understand exactly.
What do you mean with all cases?
And how should I set my conditions for testing?

You could extend your function so that it returns True for following palindromes:

1 2 3 4 5 6 7 8 9 10 11 12 13

>>> def is_palindrome(word): ...     word_start = '' ...     for letter in word: ...         word_start = letter + word_start ...         if word == word_start: ...             return True ...   ...     return False ... >>> is_palindrome('Hannah') False >>> is_palindrome('Was it a car or a cat I saw?') False

One way of doing it is to 'clean string' (convert all lowercase, remove spaces and punctuation) and only after that make the comparison.

Something along those lines:

1 2 3 4 5 6 7 8 9 10 11

>>> import string >>> def is_palindrome(text): ...     cleaned = [letter.lower() for letter in ''.join(text.split()) if letter not in string.punctuation] ...     return all(forward == backward for forward, backward in zip(cleaned, reversed(cleaned))) ... >>> is_palindrome('Was it a car or a cat I saw?') True >>> is_palindrome('Hannah') True >>> is_palindrome('better') False

It's too complex for me what you did, I'm too stupid for that.
Not that your code is bad or anything, it's just me that I don't understand.

[perfringo]

If you are learning then you are beginner, not stupid.

Just to walk through:

Our objective can be set as: 'remove whitespaces and punctuation and find out whether remaining lowercase characters are same forward and backward'

'remove whitespaces':

1	''.join(text.split())

It splits string on whitespaces and then constructs new string without them. If there are no whitespaces returns new string which is same as the old one. For more type help(str.join) into interactive interpreter (press Q to quit help)

'remove punctuation':

1	if letter not in string.punctuation

Python has built-in module named string and punctuation contains following chars (one can define it's own punctuation list/string and check against that):

1 2	>>> string.punctuation '!"#$%&\'()*+,-./:;<=>?@[\\]^_`{|}~'

'lowercase characters':

1	letter.lower()

For more information type help(str.lower) into interactive interpreter.

All these actions are put into list comprehension 'give me a lowercase letter for every letter in string without spaces which is not punctuation':

1	[letter.lower() for letter in ''.join(text.split()) if letter not in string.punctuation]

Now when we have cleaned the string (and have list instead of it) we test equality from both sides.

There is built-in function zip() which action can be described as putting iterable elements in parallel (or rows to columns or transpose):

1 2	>>> list(zip('abc', '123')) [('a', '1'), ('b', '2'), ('c', '3')]

We create pairs using zip and checking for equality of pair items. We use tuple unpacking and give names forward/backwards to appropriate element (for better readability, it could be x, y or whatever). We use reversed() function to reverse list and get order which is backwards.

1 2 3

>>> word = 'better'                                   # first and last letters are not equal >>> list(zip(word, reversed(word))) [('b', 'r'), ('e', 'e'), ('t', 't'), ('t', 't'), ('e', 'e'), ('r', 'b')]

We use built-in function all() which has short-circuiting behaviour (first False terminate the loop). It returns True only if all comparisons return True (as name suggests :-).

1	all(forward == backward for forward, backward in zip(cleaned, reversed(cleaned)))

Lot of Python built-in stuff is used, but spoken algorithm and code have good parity (and this is one of advatages of Python)

[RavCOder]

If you are learning then you are beginner, not stupid.

Just to walk through:

Our objective can be set as: 'remove whitespaces and punctuation and find out whether remaining lowercase characters are same forward and backward'

'remove whitespaces':

1	''.join(text.split())

It splits string on whitespaces and then constructs new string without them. If there are no whitespaces returns new string which is same as the old one. For more type help(str.join) into interactive interpreter (press Q to quit help)

'remove punctuation':

1	if letter not in string.punctuation

Python has built-in module named string and punctuation contains following chars (one can define it's own punctuation list/string and check against that):

1 2	>>> string.punctuation '!"#$%&\'()*+,-./:;<=>?@[\\]^_`{|}~'

'lowercase characters':

1	letter.lower()

For more information type help(str.lower) into interactive interpreter.

All these actions are put into list comprehension 'give me a lowercase letter for every letter in string without spaces which is not punctuation':

1	[letter.lower() for letter in ''.join(text.split()) if letter not in string.punctuation]

Now when we have cleaned the string (and have list instead of it) we test equality from both sides.

There is built-in function zip() which action can be described as putting iterable elements in parallel (or rows to columns or transpose):

1 2	>>> list(zip('abc', '123')) [('a', '1'), ('b', '2'), ('c', '3')]

We create pairs using zip and checking for equality of pair items. We use tuple unpacking and give names forward/backwards to appropriate element (for better readability, it could be x, y or whatever). We use reversed() function to reverse list and get order which is backwards.

We use built-in function all() which has short-circuiting behaviour (first False terminate the loop). It returns True only if all comparisons return True (as name suggests :-).

1	all(forward == backward for forward, backward in zip(cleaned, reversed(cleaned)))

Lot of Python built-in stuff is used, but spoken algorithm and code have good parity (and this is one of advatages of Python)

Thanks!!!
Now seems clearer to me than before, unfortunately as I have already said in my thread, I still don't have the most knowledge in Python and I don't know yet how to set certain logics of the exercises.
I know I have to do more exercises, but how can I do exercises if I can't even think about the solution?

[perfringo]

I know I have to do more exercises, but how can I do exercises if I can't even think about the solution?

One technique is to define you task in spoken language (what you must do to get required result). It's important that you think what (and not how) in this stage.

Like in this excercise 'remove whitespaces and punctuation and find out whether remaining lowercase characters are same forward and backward'

Now we start to break this down to smaller pieces and look for solutions in Python code:

- how remove whitespaces
- how to remove punctuation
- how to lowercase characters
- how to compare characters in string forward and backward

These are quite specific tasks and googling them (adding Python to the end) will give you a plenty of ideas how to solve them.

Without plan which is spelled out in spoken language it's (almost) impossible to code. And as you can observe: 'remove whitespaces and punctuation and find out whether remaining lowercase characters are same forward and backward' has nothing Python specific, this 'algorithm' can be used to solve this with paper and pencil. So find the solution to the problem and use whatever tools you have in your disposal :-).