Extract Strings From Text File - Out Put Results to Individual Files

[dj99]

Hi friends,

:)

im a python newbie.

I am trying to extract lines from my input file. Output the result to individual files

import os
	
	
Words=['Pear','Cherry']
	
input_file="c:/Users/Dan/Desktop/Python/Phrases.txt"

	
	
with open(input_file,'r') as inFile:
	    
	 text = inFile.read()
	 sentences = text.split(".")
	
	 for s in Words:
	  with open("%s.txt" % s, "w") as f:
	    for sentence in sentences:
	        if (any(map(lambda word: word in sentence, Words))):
	          f.write(sentence + '\n')
	

the first file results were ok. it extracted the sentences with pear in it

but the next file results - it simply out put the original phrase file.

I am not very experienced and have tried multiple things regarding outputting the results

if some one can take a look at this i would be grateful

I hope i worded my first post correctly

thank you for your time

[ichabod801]

You loop over the list Words. But in that loop, you have a map statement that uses the whole list, not the individual word for that iteration of the loop. (Note that s is a bad variable name, and since it's not clear what s is, it's not clear that it's what should be in the map statement.) So you are processing all of the words once for each word. If you look at your output file, I bet it has sentences with cherry in it.

So get rid of the map statement, and replace it with a simple if statement for s being in the sentence.

Note that you are looping through the whole file once for each word. It would probably be more efficient to loop through the file once, store sentences in a dictionary based on words they match, and then after that loop go through the stored sentences and write them to the files.

[dj99]

Thank you for those insights, let me try and experiment.

Something wasnt right, but i wasnt sure how to fix it.

i'll try again

[buran]

as a side note
instead of any(map(lambda word: word in sentence, Words))
it's better as any(word in sentence for word in Words)

[dj99]

Hi,

I tried to follow the suggestions, so far, Im at here

import os

Words=['Pear','Cherry']
	
with open('Phrases.txt','r') as inFile:
	    
	 text = inFile.read()
	 sentences = text.split(".")
	
	 for s in Words:
	  with open("%s.txt" % s, "w") as f:
	    for sentence in sentences:
	        if (any(word in sentence for word in Words)):  
	          f.write(sentence + '\n')

I do get 2 files - but not the right ouptut
Due to my errors, of not looping file correctly for the words.

[Sudhakar]

I modified your code for the last section. it works for me. please try from your end.

for s in Words:
with open("%s.txt" % s, "w") as f:
for sentence in sentences:
if( s in sentence):
f.write(sentence + '\n')

[ichabod801]

You are still checking every word for every word. You loop through pear and cherry. The first loop is for pear. And in that loop you check for both pear and cherry. The second loop is for cherry, and in that loop you check for both pear and cherry again. You need to change your if statement to be like Sudhakar's, so it only checks the word for the current loop.

[Sudhakar]

let me add python quotes for easy understanding.

for s in Words:
      with open("%s.txt" % s, "w") as f:
        for sentence in sentences:
            if( s in sentence):
                f.write(sentence + '\n')

[dj99]

Thank you for all your help.

I think i overthinked it and went off the wrong track earlier

but this does solve the issue

Thanks again to all and Have a great day!