What is wrong with the code?

[jackson111]

Hi all,

I received an email the other day requesting me to verify some code.
The code was this...

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40

import _winreg     class RegistryError(Exception):     def __init__(self, value):         self.value = value     def __str__(self):         return repr(self.value)     def getRegistryFoldersUnderParent(registry_connection, parent_folder):     all_folders = ""           try:         if registry_connection == "machine":             a_reg = _winreg.ConnectRegistry(None,_winreg.HKEY_LOCAL_MACHINE)         elif registry_connection == "user":             a_reg = _winreg.ConnectRegistry(None,_winreg.HKEY_CURRENT_USER)                  else:             raise RegistryError("Unknown registry connection type %s. Must be 'machine' or 'user'" % registry_connection)           parentKey = _winreg.OpenKey(a_reg, parent_folder)               except WindowsError as ex:         raise RegistryError(ex)     # Start on the second entry, so i=1 at start     i = 0     while True:        try:                         key = _winreg.EnumKey(parentKey, i)            all_folders+=key + " ;"            i += 1        except WindowsError as ex:            break       all_folders = all_folders[:-2]       return all_folders

I was asked what does the code do? What is wrong with it? and are there any improvements to be made?

Honestly, I'm a total beginner at this kind of thing.
It looks to me as though the code is to determine between an automated and user connection but I wouldn't be surprised to find out I'm totally wrong.
I think near the end there's a : that should be a ; but then aside from that, I can't really find any obvious issues.

I was hoping for some guidance or advice really. Somewhere I can start from to solve the problem and answer the questions.

Thanks,

[metulburr]

What is wrong with it?

The easiest way is to run it and find out if there are syntax errors. Of course you need to make an object and run each method. You should go line by line to determine what control is doing. Print variables to find out values as control moves. Your professor should have given you the knowledge to improve upon it i they require it. 

I cant run it as i am on linux.

[wavic]

It connects to Windows registry machine or user folder and returns all subkeys. I do not use Windows either but this says in the documentation

[iFunKtion]

I think near the end there's a : that should be a ; but then aside from that, I can't really find any obvious issues.

Hi there,

This is the kind of thing they give out for technical job interviews, I've had a few electronics pre interview  questions like this. Newish to programming myself, but I thought I'd throw in my thoughts on this line of your post.

So my experience of python is that it is colons ':' that get used mainly, semi colons (;) on the whole don't seem to be used much in python other than as separators. On this occasion, I would argue that all the colons here are correct and suspect that the one you are referring to is the one in the [:-2] which is standard slice notation for lists the one semi colon in the code, is in quotes, so will be part of the output either for human readable or to format the output in something like JSON format for machine readable.

Other observations just from looking at the code, are that it is unclear as to whether the code after the comment line is still part of the function, the comment is not indented, this is just an assumption, but I comment sections using the same indentation as the block being commented, so here the lack of indentation of the comment gives question as to whether the next part of the code is part of the previous function or not, so is this one of the errors?

All_folders, is it a namespace for a string or a list? it is first set up as an empty string, which is later populated as a string, then later in the code,  the same variable is being used for a list. Surely even if that variable has done it's duty, is there really a need to recycle a variable in this way, for a different usage and using a different data type? You might want to recycle a variable because you are going through a batch of things and it does not need to perpetuate, but to reuse in a completely different way is a bit strange and makes reading the code a little tricky.

I would take a guess that this might be a function for validating and logging a remote connection to a windows server. Hope this helps somewhere along the line

[nilamo]

Hi all,

I received an email the other day requesting me to verify some code.
The code was this...

Why are you responding to clearly spam email?  Have you no self respect?

[Ofnuts]

Hi all,

I received an email the other day requesting me to verify some code.
The code was this...

Why are you responding to clearly spam email?  Have you no self respect?

Spam, perhaps not... But since the kneejerk reaction of a programmer is to execute the code to see what is wrong with it, the recipient may be running some unknown and duboius code against the registry of his/her machine and utterly destroy it. So, a pretty good prank :)